HIVE-27925: Addendum: HiveConf: unify ConfVars enum and use underscore for better readability #5107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e for better readability
|
Contributor
|
LGTM (Non binding) |
InvisibleProgrammer
approved these changes
Mar 6, 2024
abstractdog
changed the title
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Mar 7, 2024
…e for better readability (apache#5107) (Kokila N reviewed by Laszlo Bodor)
dongjoon-hyun
added a commit
to apache/spark
that referenced
this pull request
Apr 2, 2024
…ctly ### What changes were proposed in this pull request? This PR aims to use `HiveConf.getConfVars` or Hive config names directly to be robust on Hive incompatibility. ### Why are the changes needed? Apache Hive 4.0.0 introduced incompatible changes on `ConfVars` enum via HIVE-27925. - apache/hive#4919 - apache/hive#5107 `HiveConf.getConfVars` or config names is more robust way to handle this incompatibility. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #45804 from dongjoon-hyun/SPARK-47679. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HiveConf: unify ConfVars enum and use underscore for better readability
Why are the changes needed?
Better readability
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Build and Unit tests.