-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-28402: Precommit tests fail with OOM when running split-19 #5372
Conversation
Quality Gate passedIssues Measures |
@simhadri-g |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reproduced locally and was checking the heap dump which is full of https://docs.gradle.com/enterprise/event-model-javadoc/com/gradle/scan/eventmodel/maven/MvnTestOutput_1_0.html events.
Please enrich the JIRA ticket with details about the root cause and solution and other than that it looks good to me.
We could also consider disabling build logs since I don't think anyone is using those at the moment.
<buildLogging>false</buildLogging>
For the record, the Jenkins build artifact |
Sure. let me update it |
We have the root cause and we have a green run so I would suggest to merge this ASAP to unblock precommits. |
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
Is the change a dependency upgrade?
How was this patch tested?
The oom on split-19 is gone after applying the fix, while the output size of test-results.tgz almost remains the same.