Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-28402: Precommit tests fail with OOM when running split-19 #5372

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

dengzhhu653
Copy link
Member

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

Is the change a dependency upgrade?

How was this patch tested?

The oom on split-19 is gone after applying the fix, while the output size of test-results.tgz almost remains the same.

Copy link

@kasakrisz
Copy link
Contributor

kasakrisz commented Jul 29, 2024

@simhadri-g
Could you please review this. it seems to be related to
https://issues.apache.org/jira/browse/HIVE-28303

Copy link
Member

@simhadri-g simhadri-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

Copy link
Member

@zabetak zabetak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reproduced locally and was checking the heap dump which is full of https://docs.gradle.com/enterprise/event-model-javadoc/com/gradle/scan/eventmodel/maven/MvnTestOutput_1_0.html events.

Please enrich the JIRA ticket with details about the root cause and solution and other than that it looks good to me.

We could also consider disabling build logs since I don't think anyone is using those at the moment.

<buildLogging>false</buildLogging>

@zabetak
Copy link
Member

zabetak commented Jul 29, 2024

For the record, the Jenkins build artifact test-results.tgz do not seem related to this configuration at all.

@dengzhhu653
Copy link
Member Author

Please enrich the JIRA ticket with details about the root cause and solution and other than that it looks good to me.

Sure. let me update it

@zabetak
Copy link
Member

zabetak commented Jul 29, 2024

We have the root cause and we have a green run so I would suggest to merge this ASAP to unblock precommits.

@dengzhhu653 dengzhhu653 merged commit c26342e into apache:master Jul 29, 2024
6 checks passed
@dengzhhu653 dengzhhu653 deleted the HIVE-28402 branch July 29, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants