HIVE-29332: StatsUtils to stop using "0" defaults on numeric columns without optional high/low info #6208
+3,498
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…without optional high/low info
konstantinb
commented
Nov 24, 2025
| keys: d_datekey (type: bigint), d_sellingseason (type: string) | ||
| null sort order: zz | ||
| Statistics: Num rows: 1 Data size: 96 Basic stats: COMPLETE Column stats: COMPLETE | ||
| Statistics: Num rows: 2 Data size: 104 Basic stats: COMPLETE Column stats: COMPLETE |
Contributor
Author
There was a problem hiding this comment.
This now accurately reflects 2 values in the "IN" clause whereas before these changes, "1" was used due to the interval of [0, 0] with the length of 1
konstantinb
commented
Nov 24, 2025
| Filter Operator | ||
| predicate: (d_year) IN (1985, 2004) (type: boolean) | ||
| Statistics: Num rows: 1 Data size: 96 Basic stats: COMPLETE Column stats: COMPLETE | ||
| Statistics: Num rows: 2 Data size: 104 Basic stats: COMPLETE Column stats: COMPLETE |
Contributor
Author
There was a problem hiding this comment.
This now accurately reflects 2 values in the "IN" clause whereas before these changes, "1" was used due to the interval of [0, 0] with the length of 1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HIVE-29332: Use null values for min/max Range values of numeric columns if the corresponding stats values are not set
Why are the changes needed?
Stats could be severely underestimated for some queries. In addition, invalid ranges like [0, -10] were theoretically possible. The following screenshot clearly highlights changes in the EXPLAIN output:
Does this PR introduce any user-facing change?
No
How was this patch tested?
with a query test file, with unittesting, and with a proprietary Hive implementation