Skip to content

Conversation

@Aggarwal-Raghav
Copy link
Contributor

This is revert of HIVE-20078

What changes were proposed in this pull request?

Check the attachements under HIVE-29340

Why are the changes needed?

Does this PR introduce any user-facing change?

Yes, Users will starts seeing rows/fields in tez-view

How was this patch tested?

On local setup

@Aggarwal-Raghav
Copy link
Contributor Author

Have made few minor custom changes:

  1. Added underscore in config name ATSHOOKQUEUECAPACITY
  2. removed numSparkJobs

@Aggarwal-Raghav
Copy link
Contributor Author

There seems to be a behaviour changes in parsing of fields in tez. For instance, in callerId the User is getting appended.
In hive3 its not there. I'll investigate this and raise another PR in Hive or Tez.

Screenshot 2025-11-25 at 11 57 27 AM

@sonarqubecloud
Copy link

CLIENT_IP_ADDRESS, HIVE_ADDRESS, HIVE_INSTANCE_TYPE, CONF, PERF, LLAP_APP_ID
};
private enum ExecutionMode {
MR, TEZ, LLAP, SPARK, NONE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SPARK and MR are no longer supported

BlockingQueue<Runnable> senderQueue = new LinkedBlockingQueue<Runnable>(queueCapacity);
senderExecutor = new ThreadPoolExecutor(1, 1, 0, TimeUnit.MILLISECONDS, senderQueue, threadFactory);

YarnConfiguration yarnConf = new YarnConfiguration();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that only supported for YARN deployments?

Copy link
Contributor Author

@Aggarwal-Raghav Aggarwal-Raghav Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tez view uses yarn timeline server to pass the query and plan. Based on the comments in ATS, yes it's for YARN deployments.

Ther was a mail thread on this https://www.mail-archive.com/dev@hive.apache.org/msg145250.html as mentioned by @zhangbutao on JIRA, but there was no response. After testing on my setup, i confirmed tez-view uses ATSHook. But query graphical plan and query string is present in DAG as well. So, the dilemma is wheter to keep ATSHook reverted as majorty info is present in DAG or re-enable it just to populate info in Hive Queries tab

CC @abstractdog

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this hook was dropped, but I think it is useful.
But my question was more about if we could tweak the YARN stuff to be cloud-native.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants