Skip to content

Conversation

@deniskuzZ
Copy link
Member

@deniskuzZ deniskuzZ commented Nov 26, 2025

What changes were proposed in this pull request?

  • Avoid RUN chown on large directories → use --chown in COPY
  • Minimize image size.
  • Enable S3 storage

Why are the changes needed?

Create production ready docker image

Does this PR introduce any user-facing change?

No

How was this patch tested?

Locally

Screenshot 2025-11-27 at 16 58 49

);
// Use UTC date to ensure reader date is same on all timezones.
LocalDate expiredDate
= LocalDateTime.ofEpochSecond((clock.getTime() - ttl) / 1000, 0, ZoneOffset.UTC).toLocalDate();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removes YARN dependency in HMS

@deniskuzZ deniskuzZ requested a review from difin November 26, 2025 19:26
RUN apt-get update && \
apt-get install -y wget

RUN tar -xzv \
Copy link
Member Author

@deniskuzZ deniskuzZ Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayushtkn anything else we could cut?

du -h /opt/hadoop
481M

418M ./share/hadoop/common/lib
423M ./share/hadoop/common

Copy link
Contributor

@difin difin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deniskuzZ deniskuzZ force-pushed the HMS_DOCKER branch 2 times, most recently from c68cd2e to 88ede49 Compare November 27, 2025 14:51
@deniskuzZ deniskuzZ force-pushed the HMS_DOCKER branch 2 times, most recently from 708f7e6 to 021da73 Compare November 27, 2025 15:25
@deniskuzZ deniskuzZ changed the title Optimize the HMS Docker image and enable S3 support HIVE-29346: Optimize the HMS Docker image and enable S3 support Nov 27, 2025
@Aggarwal-Raghav
Copy link
Contributor

LGTM +1 (non-binding)

  1. docker images size has been reduced ✅
Screenshot 2025-11-27 at 11 43 07 PM 2. S3A configs looks good ✅ 3. Was able to build docker images using `-Pdocker` profile

@sonarqubecloud
Copy link

@deniskuzZ deniskuzZ merged commit c46dbf2 into apache:master Nov 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants