Skip to content

HIVE-29386: Fix hmsbench runtime error on jdk21 #6250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dengzhhu653 merged 1 commit into from
Jan 8, 2026
Merged

HIVE-29386: Fix hmsbench runtime error on jdk21 #6250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions standalone-metastore/metastore-tools/metastore-benchmarks/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,6 @@
<artifactId>jmh-core</artifactId>
<version>${jmh.version}</version>
</dependency>
<dependency>
<groupId>org.openjdk.jmh</groupId>
<artifactId>jmh-generator-annprocess</artifactId>
<version>${jmh.version}</version>
</dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-slf4j-impl</artifactId>
Expand Down Expand Up @@ -153,6 +148,9 @@
<transformer implementation="org.apache.logging.log4j.maven.plugins.shade.transformer.Log4j2PluginCacheFileTransformer"/>
<transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
<mainClass>org.apache.hadoop.hive.metastore.tools.BenchmarkTool</mainClass>
<manifestEntries>
<Multi-Release>true</Multi-Release>
Copy link
Contributor

@Aggarwal-Raghav Aggarwal-Raghav Dec 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the dnsjava:3.6.1 jar and META-INF/versions/11 and META-INF/versions/18 were make sense to set Multi-Release to true.

Copy link
Member

@dengzhhu653 dengzhhu653 Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have full understanding of it. Could you explain a bit more please? what's if we dont add this entries

Copy link
Contributor

@Aggarwal-Raghav Aggarwal-Raghav Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dengzhhu653 , dnsjava-3.6.1 is a multi-release jar and after shading the Multi-Release tag is getting dropped from MANIFEST.MF.

I was able to repro the ERROR message present on the JIRA .
Screenshot 2026-01-05 at 12 25 22 PM

Before and after the fix,META-INF/MANIFEST.MF on hmsbench.jar
Screenshot 2026-01-05 at 12 50 10 PM

I didn't explored if there is any other way to fix this.

Copy link
Contributor Author

@wecharyu wecharyu Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a related discussion dnsjava/dnsjava#329, Multi-Release is a recommended solution.

</manifestEntries>
</transformer>
</transformers>
<filters>
Expand Down Expand Up @@ -190,6 +188,7 @@
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<fork>true</fork>
<proc>full</proc>
<compilerArgs>
<arg>-XDcompilePolicy=simple</arg>
<arg>--should-stop=ifError=FLOW</arg>
Expand All @@ -211,6 +210,11 @@
<artifactId>error_prone_core</artifactId>
<version>${errorprone.core.version}</version>
</path>
<path>
<groupId>org.openjdk.jmh</groupId>
<artifactId>jmh-generator-annprocess</artifactId>
<version>${jmh.version}</version>
</path>
</annotationProcessorPaths>
<forceJavacCompilerUse>true</forceJavacCompilerUse>
</configuration>
Expand Down