Apply spotless, fixes #3846

core/src/main/java/org/apache/hop/core/BlockingListeningRowSet.java

@@ -17,12 +17,11 @@
 
 package org.apache.hop.core;
 
-import org.apache.hop.core.row.IRowMeta;
-
 import java.util.concurrent.ArrayBlockingQueue;
 import java.util.concurrent.BlockingQueue;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicBoolean;
+import org.apache.hop.core.row.IRowMeta;
 
 /**
  * Contains a buffer of rows. Getting rows from the buffer or putting rows in the buffer is
@@ -134,7 +133,9 @@ public int size() {
     return queArray.size();
   }
 
-  /** @return true if this row set is blocking. */
+  /**
+   * @return true if this row set is blocking.
+   */
   @Override
   public boolean isBlocking() {
     return blocking.get();

core/src/main/java/org/apache/hop/core/BlockingRowSet.java

@@ -17,11 +17,10 @@
 
 package org.apache.hop.core;
 
-import org.apache.hop.core.row.IRowMeta;
-
 import java.util.concurrent.ArrayBlockingQueue;
 import java.util.concurrent.BlockingQueue;
 import java.util.concurrent.TimeUnit;
+import org.apache.hop.core.row.IRowMeta;
 
 /**
  * Contains a buffer of rows. Getting rows from the buffer or putting rows in the buffer is

core/src/main/java/org/apache/hop/core/CheckResult.java

@@ -88,13 +88,17 @@ public String toString() {
     return sb.toString();
   }
 
-  /** @return the errorCode */
+  /**
+   * @return the errorCode
+   */
   @Override
   public String getErrorCode() {
     return errorCode;
   }
 
-  /** @param errorCode the errorCode to set */
+  /**
+   * @param errorCode the errorCode to set
+   */
   @Override
   public void setErrorCode(String errorCode) {
     this.errorCode = errorCode;

core/src/main/java/org/apache/hop/core/Condition.java

@@ -17,6 +17,13 @@
 
 package org.apache.hop.core;
 
+import static org.apache.hop.core.Condition.Function.EQUAL;
+import static org.apache.hop.core.Condition.Function.NOT_NULL;
+import static org.apache.hop.core.Condition.Function.NULL;
+import static org.apache.hop.core.Condition.Function.TRUE;
+import static org.apache.hop.core.Condition.Operator.AND;
+import static org.apache.hop.core.Condition.Operator.NONE;
+
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.HashMap;
@@ -41,13 +48,6 @@
 import org.apache.hop.metadata.serializer.xml.XmlMetadataUtil;
 import org.w3c.dom.Node;
 
-import static org.apache.hop.core.Condition.Function.EQUAL;
-import static org.apache.hop.core.Condition.Function.NOT_NULL;
-import static org.apache.hop.core.Condition.Function.NULL;
-import static org.apache.hop.core.Condition.Function.TRUE;
-import static org.apache.hop.core.Condition.Operator.AND;
-import static org.apache.hop.core.Condition.Operator.NONE;
-
 /**
  * This class describes a condition in a general meaning.
  *

core/src/main/java/org/apache/hop/core/Counter.java

@@ -59,47 +59,65 @@ public Counter(long start, long increment, long maximum) {
     this.maximum = maximum;
   }
 
-  /** @return Returns the counter. */
+  /**
+   * @return Returns the counter.
+   */
   public long getCounter() {
     return counterValue;
   }
 
-  /** @return Returns the increment. */
+  /**
+   * @return Returns the increment.
+   */
   public long getIncrement() {
     return increment;
   }
 
-  /** @return Returns the maximum. */
+  /**
+   * @return Returns the maximum.
+   */
   public long getMaximum() {
     return maximum;
   }
 
-  /** @return Returns the start. */
+  /**
+   * @return Returns the start.
+   */
   public long getStart() {
     return start;
   }
 
-  /** @return Returns the loop. */
+  /**
+   * @return Returns the loop.
+   */
   public boolean isLoop() {
     return loop;
   }
 
-  /** @param counter The counter to set. */
+  /**
+   * @param counter The counter to set.
+   */
   public void setCounter(long counter) {
     this.counterValue = counter;
   }
 
-  /** @param increment The increment to set. */
+  /**
+   * @param increment The increment to set.
+   */
   public void setIncrement(long increment) {
     this.increment = increment;
   }
 
-  /** @param loop The loop to set. */
+  /**
+   * @param loop The loop to set.
+   */
   public void setLoop(boolean loop) {
     this.loop = loop;
   }
 
-  /** @param maximum The maximum to set. */
+  /**
+   * @param maximum The maximum to set.
+   */
   public void setMaximum(long maximum) {
     this.maximum = maximum;
   }

core/src/main/java/org/apache/hop/core/DbCache.java

@@ -17,13 +17,6 @@
 
 package org.apache.hop.core;
 
-import org.apache.hop.core.exception.HopEofException;
-import org.apache.hop.core.exception.HopFileException;
-import org.apache.hop.core.logging.ILogChannel;
-import org.apache.hop.core.logging.LogChannel;
-import org.apache.hop.core.row.IRowMeta;
-import org.apache.hop.core.row.RowMeta;
-
 import java.io.BufferedOutputStream;
 import java.io.DataInputStream;
 import java.io.DataOutputStream;
@@ -32,6 +25,12 @@
 import java.io.FileOutputStream;
 import java.util.Enumeration;
 import java.util.Hashtable;
+import org.apache.hop.core.exception.HopEofException;
+import org.apache.hop.core.exception.HopFileException;
+import org.apache.hop.core.logging.ILogChannel;
+import org.apache.hop.core.logging.LogChannel;
+import org.apache.hop.core.row.IRowMeta;
+import org.apache.hop.core.row.RowMeta;
 
 /**
  * This class caches database queries so that the same query doesn't get called twice. Queries are

core/src/main/java/org/apache/hop/core/DbCacheEntry.java

@@ -17,12 +17,11 @@
 
 package org.apache.hop.core;
 
-import org.apache.hop.core.exception.HopEofException;
-import org.apache.hop.core.exception.HopFileException;
-
 import java.io.DataInputStream;
 import java.io.DataOutputStream;
 import java.io.EOFException;
+import org.apache.hop.core.exception.HopEofException;
+import org.apache.hop.core.exception.HopFileException;
 
 /**
  * This class represents a single entry in a database cache. A single entry in this case usually

core/src/main/java/org/apache/hop/core/HopAttribute.java

@@ -57,57 +57,77 @@ public void setKey(String key) {
     this.key = key;
   }
 
-  /** @return the xmlCode */
+  /**
+   * @return the xmlCode
+   */
   @Override
   public String getXmlCode() {
     return xmlCode;
   }
 
-  /** @param xmlCode the xmlCode to set */
+  /**
+   * @param xmlCode the xmlCode to set
+   */
   public void setXmlCode(String xmlCode) {
     this.xmlCode = xmlCode;
   }
 
-  /** @return the description */
+  /**
+   * @return the description
+   */
   @Override
   public String getDescription() {
     return description;
   }
 
-  /** @param description the description to set */
+  /**
+   * @param description the description to set
+   */
   public void setDescription(String description) {
     this.description = description;
   }
 
-  /** @return the tooltip */
+  /**
+   * @return the tooltip
+   */
   @Override
   public String getTooltip() {
     return tooltip;
   }
 
-  /** @param tooltip the tooltip to set */
+  /**
+   * @param tooltip the tooltip to set
+   */
   public void setTooltip(String tooltip) {
     this.tooltip = tooltip;
   }
 
-  /** @return the type */
+  /**
+   * @return the type
+   */
   @Override
   public int getType() {
     return type;
   }
 
-  /** @param type the type to set */
+  /**
+   * @param type the type to set
+   */
   public void setType(int type) {
     this.type = type;
   }
 
-  /** @return the parent */
+  /**
+   * @return the parent
+   */
   @Override
   public IHopAttribute getParent() {
     return parent;
   }
 
-  /** @param parent the parent to set */
+  /**
+   * @param parent the parent to set
+   */
   public void setParent(IHopAttribute parent) {
     this.parent = parent;
   }

core/src/main/java/org/apache/hop/core/HopClientEnvironment.java

@@ -17,6 +17,12 @@
 
 package org.apache.hop.core;
 
+import java.lang.reflect.Field;
+import java.lang.reflect.Method;
+import java.util.ArrayList;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
 import org.apache.hop.core.database.DatabasePluginType;
 import org.apache.hop.core.encryption.Encr;
 import org.apache.hop.core.encryption.TwoWayPasswordEncoderPluginType;
@@ -36,13 +42,6 @@
 import org.apache.hop.core.vfs.HopVfs;
 import org.apache.hop.core.vfs.plugin.VfsPluginType;
 
-import java.lang.reflect.Field;
-import java.lang.reflect.Method;
-import java.util.ArrayList;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Set;
-
 /**
  * This singleton is responsible for initializing the Hop client environment and remembering if it
  * is initialized. More specifically it loads client plugins like value meta plugins and other core

core/src/main/java/org/apache/hop/core/IAttributes.java

@@ -28,7 +28,9 @@ public interface IAttributes {
    */
   void setAttributesMap(Map<String, Map<String, String>> attributesMap);
 
-  /** @return All attributes for all attribute groups in one single map. */
+  /**
+   * @return All attributes for all attribute groups in one single map.
+   */
   Map<String, Map<String, String>> getAttributesMap();
 
   /**

core/src/main/java/org/apache/hop/core/ICheckResult.java

@@ -29,23 +29,35 @@ public interface ICheckResult {
 
   int TYPE_RESULT_ERROR = 4;
 
-  /** @return The type of the Check Result (0-4) */
+  /**
+   * @return The type of the Check Result (0-4)
+   */
   int getType();
 
-  /** @return The internationalized type description */
+  /**
+   * @return The internationalized type description
+   */
   String getTypeDesc();
 
-  /** @return The text of the check result. */
+  /**
+   * @return The text of the check result.
+   */
   String getText();
 
-  /** @return The source of the check result */
+  /**
+   * @return The source of the check result
+   */
   ICheckResultSource getSourceInfo();
 
-  /** @return String description of the check result */
+  /**
+   * @return String description of the check result
+   */
   @Override
   String toString();
 
-  /** @return The component-specific result code. */
+  /**
+   * @return The component-specific result code.
+   */
   String getErrorCode();
 
   /**

core/src/main/java/org/apache/hop/core/ICheckResultSource.java

@@ -22,9 +22,13 @@
  * CheckResult remark.
  */
 public interface ICheckResultSource {
-  /** @return The name of the source generating the CheckResult */
+  /**
+   * @return The name of the source generating the CheckResult
+   */
   String getName();
 
-  /** @return The description of the source generating the CheckResult */
+  /**
+   * @return The description of the source generating the CheckResult
+   */
   String getDescription();
 }