Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: When viewing remote results, the workflow containing Chinese characters appears garbled #3590

Closed
ahai-code opened this issue Jan 29, 2024 · 11 comments · Fixed by #3599 or #3726
Closed
Assignees
Milestone

Comments

@ahai-code
Copy link

Apache Hop version?

2.6.0

Java version?

11.0.2

Operating system

Windows

What happened?

I created a workflow (this workflow contains Chinese characters), see Figure 1, using the remote (Hop remote workflow engine) way to run, the output of the log is normal, but when I view the results (Location type is Remote location, see Figure 2) appeared garbled, see Figure 3.
image
image (1)
image (2)

Issue Priority

Priority: 2

Issue Component

Component: Actions, Component: API, Component: Hop Gui, Component: Hop Server

@hansva
Copy link
Contributor

hansva commented Jan 29, 2024

Could you test with Hop 2.7, this issue should be resolved #3356

@ahai-code
Copy link
Author

Thanks a lot for the answer, I tested again with the latest version 2.7.0 (client and docker image) but the issue persists, maybe it is different from #3356.

@nadment
Copy link
Contributor

nadment commented Jan 31, 2024

The same problem is also visible in the metrics tab (2.8.0-SNAPSHOT (2024-01-24 07.28.10)).

Local execution
image

Remote server execution
image

@nadment nadment self-assigned this Jan 31, 2024
nadment added a commit to nadment/hop that referenced this issue Jan 31, 2024
@nadment nadment linked a pull request Jan 31, 2024 that will close this issue
@nadment
Copy link
Contributor

nadment commented Jan 31, 2024

Charset problems seem to have been corrected with #3599

image

usbrandon added a commit that referenced this issue Feb 1, 2024
Fix HopServer charset decoding to UTF-8 #3590
@hansva hansva added this to the 2.8 milestone Feb 12, 2024
bamaer pushed a commit to bamaer/hop that referenced this issue Feb 24, 2024
@ahai-code
Copy link
Author

The problem doesn't seem to be completely solved, I downloaded the latest version 2.8.0, created a workflow to test it, and there is still Chinese gibberish when getting the workflow remote results.

Figure 1. Workflow remote logs print properly.
1710688660078

Figure 2. Workflow remote results appear garbled, including the workflow name, log, and the name of the action in the workflow.
1710688700505

Figure 3. Double-click to enter the operation of the pipeline type, which also has a lot of garbled code, including pipeline names, conversion names and logs, etc.
1710688752358

@nadment
Copy link
Contributor

nadment commented Mar 17, 2024

I'm reopening the issue. I reproduce the bug with the following "Execution Information Location".
There's another bug in GetExecutionInfoServlet

image

The problem now seems to have been solved in remote execution location too.
image

@nadment nadment reopened this Mar 17, 2024
nadment added a commit to nadment/hop that referenced this issue Mar 17, 2024
@nadment nadment linked a pull request Mar 17, 2024 that will close this issue
usbrandon added a commit that referenced this issue Mar 18, 2024
Set character encoding before getting writer #3590
@hansva
Copy link
Contributor

hansva commented Mar 18, 2024

@ahai-code, could you test with a latest build from here then we know the issues are resolved in the next version

@ahai-code
Copy link
Author

Well, I downloaded "hop-client-2.9.0-20240318.234909-1.zip" from the link, and hop-server (Docker image) is still using 2.8.0, and testing revealed that when using the remote method to run the workflow and pipeline, this error message appears, as shown in Figure 1. Is it because I am not using the same version (2.9.0-20240318.234909-1) of the Docker image as the client?
1710840398612
1710840503391

@hansva
Copy link
Contributor

hansva commented Mar 19, 2024

Hi @ahai-code for docker images you can use the 2.9.0-SNAPSHOT or Development tags:
https://hub.docker.com/r/apache/hop/tags

@ahai-code
Copy link
Author

@hansva Thank you, it's because the client and hop server versions are not the same. And I just created a remote workflow to test it, and the garbled Chinese issue is resolved. @nadment Thank you again for your patience in solving this problem, which has helped me a lot in using the software.
1710852237629

@hansva
Copy link
Contributor

hansva commented Mar 19, 2024

Thank you for confirming it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants