Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Parameters/variables grids do not reliably delete rows #3712

Closed
davemc50 opened this issue Mar 12, 2024 · 2 comments · Fixed by #3787
Closed

[Bug]: Parameters/variables grids do not reliably delete rows #3712

davemc50 opened this issue Mar 12, 2024 · 2 comments · Fixed by #3787
Assignees
Labels
Milestone

Comments

@davemc50
Copy link

Apache Hop version?

2.7

Java version?

11.0.02

Operating system

Linux

What happened?

Create some rows in a properties dialog, like properties/variables to set, in the desktop gui on linux, in the pipeline or workflow editor.

Press the rubbish bin button to delete a row

Either the wrong row gets deleted (the one above or below), or the next field right's deleted value persists over the top of the retained row. Doesn't happen all the time, but often enough that every delete needs to be treated with caution.

There are some grid refresh events that seem to happen, like the cached grid contents is unaware of the delete, and repopulates the gird with stale values. Could also be that the grid doesn't have proper row ids or sequence id's in the background, and is getting muddled about which row should be deleted.

Issue Priority

Priority: 3

Issue Component

Component: Hop Gui

@hansva
Copy link
Contributor

hansva commented Mar 25, 2024

can confirm that you have to make sure you have a line selected and are not in a field.
When you are in a field the delete is not acting the way it's supposed to

@nadment nadment self-assigned this Apr 7, 2024
nadment added a commit to nadment/hop that referenced this issue Apr 7, 2024
nadment added a commit to nadment/hop that referenced this issue Apr 7, 2024
nadment added a commit to nadment/hop that referenced this issue Apr 7, 2024
@nadment nadment added this to the 2.9 milestone Apr 7, 2024
@nadment nadment linked a pull request Apr 7, 2024 that will close this issue
nadment added a commit to nadment/hop that referenced this issue Apr 7, 2024
usbrandon added a commit that referenced this issue Apr 9, 2024
TableView do not reliably delete rows #3712, #3767
@pauloricardoferreira
Copy link

I checked the version in question, and everything is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants