Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: workflows are missing a ExecutionStoppedListener #3715

Closed
hansva opened this issue Mar 13, 2024 · 4 comments · Fixed by #3898
Closed

[Feature Request]: workflows are missing a ExecutionStoppedListener #3715

hansva opened this issue Mar 13, 2024 · 4 comments · Fixed by #3898
Assignees
@hansva @nadment
Labels
API new feature P2 Default Priority
Milestone
2.9

Comments

@hansva
Copy link
Contributor

hansva commented Mar 13, 2024

What would you like to happen?

Add ExecutionStoppedListener to Workflows too in analogy with pipelines

Issue Priority

Priority: 2

Issue Component

Component: API
@github-actions github-actions bot added P2 Default Priority API labels Mar 13, 2024
@hansva
Copy link
Contributor Author

hansva commented Mar 13, 2024

.take-issue

@nadment nadment self-assigned this Apr 8, 2024
@nadment
Copy link
Contributor

nadment commented Apr 9, 2024 •
edited
Loading

I'd also be tempted to standardize methods between IPipelineEngine and IWorkflowEngine.
image

Or a variant but even more API break:
[add][remove]PipelineExecutionStartedListener
[fire]PipelineExecutionStartedListener
[add][remove]WorkflowExecutionStartedListener
[fire]WorkflowExecutionStartedListener

Do we have to wait for version 3.0 for such changes?

@hansva
Copy link
Contributor Author

hansva commented Apr 9, 2024

I don't think we have to wait for a 3.0 version for this. You might have also noticed with your work that the pipeline finished listener is triggered too soon, not all transforms have finished when it is triggered

@nadment
Copy link
Contributor

nadment commented Apr 9, 2024

I've seen bug #3675 but haven't seen it in action yet. I'll keep an eye out for it.

nadment added a commit to nadment/hop that referenced this issue Apr 29, 2024
@nadment
Add IExecutionStoppedListener to IWorkflowEngine apache#3715
7384ff5 
Standardize method names between Workflow and Pipeline and deprecate
obsolete methods.
Fix some synchronized listener errors in Pipeline
Define the date of the workflow's end of execution before calling the
extension points
Remove unused IFinishedListener
@nadment nadment linked a pull request Apr 29, 2024 that will close this issue
Add IExecutionStoppedListener to IWorkflowEngine #3715 #3898
Merged
hansva added a commit that referenced this issue May 3, 2024
@hansva
Merge pull request #3898 from nadment/3715
fe01692 
Add IExecutionStoppedListener to IWorkflowEngine  #3715
@hansva hansva added this to the 2.9 milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hansva hansva

@nadment nadment

Labels
API new feature P2 Default Priority
Projects
None yet
Milestone
2.9
Development

Successfully merging a pull request may close this issue.

Add IExecutionStoppedListener to IWorkflowEngine #3715 nadment/hop
2 participants
@hansva @nadment