Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Changing the field a changing sequence depends on crashes the app. #3815

Closed
usbrandon opened this issue Apr 16, 2024 · 4 comments · Fixed by #3868
Closed

[Bug]: Changing the field a changing sequence depends on crashes the app. #3815

usbrandon opened this issue Apr 16, 2024 · 4 comments · Fixed by #3868
Assignees
Labels
bug Hop Gui P2 Default Priority
Milestone

Comments

@usbrandon
Copy link
Contributor

Apache Hop version?

2.8-GA

Java version?

11

Operating system

Windows

What happened?

I expected when there is not perfect alignment to what field should be used to receive an error and not crash the application.

You can reproduce this error by configuring your pipeline to use a "Changing Sequence" transform and designate an existing column to change the output sequence based upon changes to that field.

Then change that field to something that does not exist in the stream and click run. Hop will hang indefinitely. It just should throw an error, stop the transform and let the user continue working.

ms.fieldschangesequence.FieldsChangeSequenceField@ab5f359] in the input stream!
org.apache.hop.core.exception.HopException:
Can not find field [org.apache.hop.pipeline.transforms.fieldschangesequence.FieldsChangeSequenceField@ab5f359] in the input stream!

    at org.apache.hop.pipeline.transforms.fieldschangesequence.FieldsChangeSequence.processRow(FieldsChangeSequence.java:75)
    at org.apache.hop.pipeline.transform.RunThread.run(RunThread.java:55)
    at java.base/java.lang.Thread.run(Thread.java:840)

2024/04/16 11:54:02 - Add value fields changing sequence.0 - ERROR: Unexpected error
2024/04/16 11:54:02 - Add value fields changing sequence.0 - ERROR: org.apache.hop.core.exception.HopException:
2024/04/16 11:54:02 - Add value fields changing sequence.0 - Can not find field [org.apache.hop.pipeline.transforms.fieldschangesequence.FieldsChangeSequenceField@ab5f359] in the input stream!
2024/04/16 11:54:02 - Add value fields changing sequence.0 -
2024/04/16 11:54:02 - Add value fields changing sequence.0 - at org.apache.hop.pipeline.transforms.fieldschangesequence.FieldsChangeSequence.processRow(FieldsChangeSequence.java:75)
2024/04/16 11:54:02 - Add value fields changing sequence.0 - at org.apache.hop.pipeline.transform.RunThread.run(RunThread.java:55)

Issue Priority

Priority: 2

Issue Component

Component: Hop Gui

@gertwieland
Copy link

I wholeheartedly support this.
Probably related to ticket 3655

@gertwieland
Copy link

image

@bamaer
Copy link
Contributor

bamaer commented Apr 17, 2024

tried to reproduce this on Linux and Mac, but Hop Gui keeps working correctly after the error. I'll see if I can test this on Windows one of these days too.

@nadment
Copy link
Contributor

nadment commented Apr 26, 2024

Works on Windows too, but the error message should be improved with the field name:

AS IS: Can not find field [org.apache.hop.pipeline.transforms.fieldschangesequence.FieldsChangeSequenceField@337aaa] in the input stream!

TO BE: Can not find field [fieldname] in the input stream!

hansva added a commit that referenced this issue Apr 26, 2024
Improves error message for Changing sequence transformation #3815
@hansva hansva added this to the 2.9 milestone Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Hop Gui P2 Default Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants