Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Documentation improvement - Metadata injection #4025

Closed
dave-csc opened this issue Jun 6, 2024 · 0 comments · Fixed by #4047
Closed

[Task]: Documentation improvement - Metadata injection #4025

dave-csc opened this issue Jun 6, 2024 · 0 comments · Fixed by #4047

Comments

@dave-csc
Copy link
Contributor

dave-csc commented Jun 6, 2024

What needs to happen?

The Metadata Injection documentation should be improved for those transforms that have (in their GUI) options in a combobox or similar, especially when their text doesn't fit with what the Metadata injection procedure needs to receive.

Example: the Calculator transform, at the row List of calculations -> Calculation type, requires one of the values defined in the CalculatorMetaFunction$CalculationType enum (e.g. ADD_TIME_TO_DATE) and not the corresponding description in the GUI (Add time B to date A).

Issue Priority

Priority: 3

Issue Component

Component: Documentation, Component: Transforms

dave-csc added a commit to dave-csc/hop that referenced this issue Jun 12, 2024
Added descriptions for Metadata Injection as suggested, and "Metadata Injection support" paragraph
Added rows for 6 undocumented functions in Calculator (last 6 in the table)
Beware that ROUND_CUSTOM_1 and ROUND_CUSTOM_2 seem not to be actually implemented!
dave-csc added a commit to dave-csc/hop that referenced this issue Jun 12, 2024
* Fix apache#4025 - Update calculator.adoc

Added descriptions for Metadata Injection as suggested, and "Metadata Injection support" paragraph
Added rows for 6 undocumented functions in Calculator (last 6 in the table)
Beware that ROUND_CUSTOM_1 and ROUND_CUSTOM_2 seem not to be actually implemented!
hansva added a commit that referenced this issue Jun 19, 2024
Fix #4025 - Update calculator.adoc (#1)
@hansva hansva added this to the 2.10 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants