Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3666, fix #3588, fix #3738 #3673

Merged
merged 4 commits into from
Mar 25, 2024
Merged

fix #3666, fix #3588, fix #3738 #3673

merged 4 commits into from
Mar 25, 2024

Conversation

sramazzina
Copy link
Contributor

@sramazzina sramazzina commented Feb 26, 2024

fix #3666 - DuckDB - Explorer shows multiple entries for schemas. Tables and Views not populated in their sections.
fix #3588 - Show layout in database explorer don't work
fix #3738 - DuckDB ALTER COLUMN statement not working


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

…ily removed GetQueryFieldsProgressDialog because buggy and opened the dataset directly.
@sramazzina sramazzina changed the title fix #3666 fix #3666, fix #3588 Feb 26, 2024
@sramazzina
Copy link
Contributor Author

The show layout dialog must be completely rewritten because the current dialog is completely out of context. In any case the issue is now fixed

@sramazzina sramazzina marked this pull request as draft February 27, 2024 08:18
@sramazzina
Copy link
Contributor Author

sramazzina commented Feb 27, 2024

I put the PR in draft waiting to do more tests with some commonly used databases.

@sramazzina sramazzina added this to the 2.9 milestone Mar 4, 2024
@sramazzina sramazzina marked this pull request as ready for review March 19, 2024 21:30
@sramazzina
Copy link
Contributor Author

Tested on MySQL, PostgreSQL, DuckDB and SQL Server with success. In my opinion this PR can be merged

@sramazzina sramazzina changed the title fix #3666, fix #3588 fix #3666, fix #3588, fix #3738 Mar 19, 2024
@hansva hansva merged commit 2d35b8f into apache:master Mar 25, 2024
2 checks passed
@hansva hansva removed this from the 2.9 milestone May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants