3790 - Support CrateDB database plugin #3791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdelox
force-pushed
the
3790-cratedb-connection
branch
from
9da3b7c
to
3171c0e
Compare
|
Looks good, @xdelox. The only thing that seems missing is the doc page. |
xdelox
force-pushed
the
3790-cratedb-connection
branch
from
3171c0e
to
bb40afe
Compare
xdelox
force-pushed
the
3790-cratedb-connection
branch
from
bb40afe
to
c92d910
Compare
hansva
requested changes
Apr 15, 2024
...atabases/cratedb/src/test/java/org/apache/hop/databases/cratedb/CrateDBDatabaseMetaTest.java
Outdated
Show resolved
Hide resolved
...atabases/cratedb/src/test/java/org/apache/hop/databases/cratedb/CrateDBDatabaseMetaTest.java
Outdated
Show resolved
Hide resolved
...tabases/cratedb/src/test/java/org/apache/hop/databases/cratedb/CrateDBValueMetaBaseTest.java
Outdated
Show resolved
Hide resolved
...tabases/cratedb/src/test/java/org/apache/hop/databases/cratedb/CrateDBValueMetaBaseTest.java
Outdated
Show resolved
Hide resolved
...tabases/cratedb/src/test/java/org/apache/hop/databases/cratedb/CrateDBValueMetaBaseTest.java
Outdated
Show resolved
Hide resolved
xdelox
force-pushed
the
3790-cratedb-connection
branch
3 times, most recently
from
f7386ed
to
133d536
Compare
hansva
approved these changes
Apr 15, 2024
xdelox
force-pushed
the
3790-cratedb-connection
branch
from
133d536
to
3167cc7
Compare
Comment on lines
+83
to
+87
| public void sqlStatements() throws Exception { | ||
| executeUpdate( | ||
| "INSERT INTO foo (id, name, description) VALUES (1, 'Alice', 'test_description');"); | ||
| Thread.sleep(1500); // need a break to make sure the data is there: unfortunately, | ||
| // CrateDB does not support transactions, rather it promote eventual consistency. |
There was a problem hiding this comment.
Hi, thanks for adding CrateDB support!
FYI: you can use refresh table foo after insert statement. https://cratedb.com/docs/crate/reference/en/5.6/general/dql/refresh.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean install apache-rat:checkto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i.addresses #123), if applicable.To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.