Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3867 #3878

Merged
merged 3 commits into from
May 7, 2024
Merged

fix #3867 #3878

merged 3 commits into from
May 7, 2024

Conversation

sramazzina
Copy link
Contributor

@sramazzina sramazzina commented Apr 26, 2024

fix #3867 - Unit test action: dialog improvement


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@hansva
Copy link
Contributor

hansva commented May 3, 2024

TBH... I hate the dialog you used.
there are multiple things wrong with that dialog on MacOS:

  • It expands beyond the reach of your window
  • when closing it with escape Hop just moves around (and I have to use escape because I can't reach the buttons)
  • It doesn't allow multi-select which might be useful in this case

None of these problems are introduced by you.

The only remark I have which you can handle in this PR is the name on the list when opening the dialo:
image

Should be please select the unit test or something like that.

@sramazzina
Copy link
Contributor Author

sramazzina commented May 6, 2024

@hansva sorry for the wrong label name I've not noticed :-( . I will fix it

@sramazzina
Copy link
Contributor Author

@hansva, unfortunately, the only thing I'm able to fix is the label. Multiple selection (that I agree with you is not completed in the EnterSelectionDialog therefore it cannot be used. About the hieght of the dialog I'm to find out a way to set the height of the dialog but it seems not that easy. Let me know your opinion about confirming to move forward with this improvement or if we want to throw everything away and leave the things as they are.

@hansva
Copy link
Contributor

hansva commented May 7, 2024

As stated in my previous comment, nothing you can do about it in this ticket. Just some personal frustration flowing out.
Thanks for the change LGTM

@sramazzina
Copy link
Contributor Author

Yeah I understand and I agree with you

@hansva hansva merged commit 892648c into apache:main May 7, 2024
2 checks passed
@github-actions github-actions bot added this to the 2.9 milestone May 7, 2024
@hansva
Copy link
Contributor

hansva commented May 7, 2024

right, a mixup happened in the issue number, for reference this is for #3867

@sramazzina sramazzina deleted the 3867 branch May 7, 2024 10:48
@hansva hansva removed this from the 2.9 milestone May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Unit test action: dialog improvement
2 participants