Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3321 improved documentation #3980

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Fix #3321 improved documentation #3980

merged 2 commits into from
Jun 5, 2024

Conversation

dsanderbi
Copy link
Contributor

@dsanderbi dsanderbi commented May 25, 2024

Adapted "Set Variables" documentation.

Sample is added here as suggested by @hansva
samples.zip


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@dsanderbi
Copy link
Contributor Author

@hansva i'll also include the example.

@dsanderbi dsanderbi marked this pull request as draft June 4, 2024 17:08
@hansva
Copy link
Contributor

hansva commented Jun 5, 2024

PR looks great, thanks for the work @dsanderbi !

@hansva hansva marked this pull request as ready for review June 5, 2024 13:44
@hansva hansva merged commit 2ef60cf into apache:main Jun 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants