[SONAR] cleanup

core/src/main/java/org/apache/hop/core/LogProgressMonitor.java

@@ -44,10 +44,14 @@ public boolean isCanceled() {
   }
 
   @Override
-  public void worked(int nrWorks) {}
+  public void worked(int nrWorks) {
+    // Do nothing
+  }
 
   @Override
-  public void done() {}
+  public void done() {
+    // Do nothing
+  }
 
   @Override
   public void setTaskName(String taskName) {

core/src/main/java/org/apache/hop/core/config/ConfigNoFileSerializer.java

@@ -24,7 +24,9 @@
 
 public class ConfigNoFileSerializer implements IHopConfigSerializer {
   @Override
-  public void writeToFile(String filename, Map<String, Object> configMap) throws HopException {}
+  public void writeToFile(String filename, Map<String, Object> configMap) throws HopException {
+    // Do nothing
+  }
 
   @Override
   public Map<String, Object> readFromFile(String filename) throws HopException {

core/src/main/java/org/apache/hop/core/config/plugin/ConfigPluginType.java

@@ -75,7 +75,9 @@ protected boolean extractSeparateClassLoader(ConfigPlugin annotation) {
 
   @Override
   protected void addExtraClasses(
-      Map<Class<?>, String> classMap, Class<?> clazz, ConfigPlugin annotation) {}
+      Map<Class<?>, String> classMap, Class<?> clazz, ConfigPlugin annotation) {
+    // Do nothing
+  }
 
   @Override
   protected String extractDocumentationUrl(ConfigPlugin annotation) {

core/src/main/java/org/apache/hop/core/database/DatabaseFactory.java

@@ -34,7 +34,9 @@ public class DatabaseFactory implements IDatabaseFactory {
   public static final ILoggingObject loggingObject =
       new SimpleLoggingObject("Database factory", LoggingObjectType.GENERAL, null);
 
-  public DatabaseFactory() {}
+  public DatabaseFactory() {
+    // Do nothing
+  }
 
   @Override
   public String getConnectionTestReport(IVariables variables, DatabaseMeta databaseMeta)

core/src/main/java/org/apache/hop/core/database/DatabasePluginType.java

@@ -81,7 +81,9 @@ protected boolean extractSeparateClassLoader(DatabaseMetaPlugin annotation) {
 
   @Override
   protected void addExtraClasses(
-      Map<Class<?>, String> classMap, Class<?> clazz, DatabaseMetaPlugin annotation) {}
+      Map<Class<?>, String> classMap, Class<?> clazz, DatabaseMetaPlugin annotation) {
+    // Do nothing
+  }
 
   @Override
   protected String extractDocumentationUrl(DatabaseMetaPlugin annotation) {

core/src/main/java/org/apache/hop/core/encryption/Encr.java

@@ -33,7 +33,9 @@ public class Encr {
 
   private static ITwoWayPasswordEncoder encoder;
 
-  public Encr() {}
+  public Encr() {
+    // Do nothing
+  }
 
   public static void init(String encoderPluginId) throws HopException {
     if (Utils.isEmpty(encoderPluginId)) {

core/src/main/java/org/apache/hop/core/encryption/TwoWayPasswordEncoderPluginType.java

@@ -73,7 +73,9 @@ protected boolean extractSeparateClassLoader(TwoWayPasswordEncoderPlugin annotat
 
   @Override
   protected void addExtraClasses(
-      Map<Class<?>, String> classMap, Class<?> clazz, TwoWayPasswordEncoderPlugin annotation) {}
+      Map<Class<?>, String> classMap, Class<?> clazz, TwoWayPasswordEncoderPlugin annotation) {
+    // Do nothing
+  }
 
   @Override
   protected String extractDocumentationUrl(TwoWayPasswordEncoderPlugin annotation) {

core/src/main/java/org/apache/hop/core/extension/ExtensionPointPluginType.java

@@ -75,7 +75,9 @@ protected boolean extractSeparateClassLoader(ExtensionPoint annotation) {
 
   @Override
   protected void addExtraClasses(
-      Map<Class<?>, String> classMap, Class<?> clazz, ExtensionPoint annotation) {}
+      Map<Class<?>, String> classMap, Class<?> clazz, ExtensionPoint annotation) {
+    // Do nothing
+  }
 
   @Override
   protected String extractDocumentationUrl(ExtensionPoint annotation) {

core/src/main/java/org/apache/hop/core/fileinput/NonAccessibleFileObject.java

@@ -45,7 +45,9 @@ public boolean canRenameTo(FileObject arg0) {
   }
 
   @Override
-  public void close() throws FileSystemException {}
+  public void close() throws FileSystemException {
+    // Do nothing
+  }
 
   @Override
   public void copyFrom(FileObject arg0, FileSelector arg1) throws FileSystemException {
@@ -192,7 +194,9 @@ public void moveTo(FileObject arg0) throws FileSystemException {
   }
 
   @Override
-  public void refresh() throws FileSystemException {}
+  public void refresh() throws FileSystemException {
+    // Do nothing
+  }
 
   @Override
   public FileObject resolveFile(String arg0) throws FileSystemException {

core/src/main/java/org/apache/hop/core/gui/plugin/GuiPluginType.java

@@ -73,7 +73,9 @@ protected boolean extractSeparateClassLoader(GuiPlugin annotation) {
 
   @Override
   protected void addExtraClasses(
-      Map<Class<?>, String> classMap, Class<?> clazz, GuiPlugin annotation) {}
+      Map<Class<?>, String> classMap, Class<?> clazz, GuiPlugin annotation) {
+    // Do nothing
+  }
 
   @Override
   protected String extractDocumentationUrl(GuiPlugin annotation) {

core/src/main/java/org/apache/hop/core/gui/plugin/action/GuiActionLambdaBuilder.java

@@ -24,7 +24,9 @@
 
 public class GuiActionLambdaBuilder<T> {
 
-  public GuiActionLambdaBuilder() {}
+  public GuiActionLambdaBuilder() {
+    // Do nothing
+  }
 
   /**
    * Create a copy of the given action and create an action lambda for it.

core/src/main/java/org/apache/hop/core/gui/plugin/toolbar/EmptyTypeFilename.java

@@ -21,7 +21,9 @@
 
 public class EmptyTypeFilename implements ITypeFilename {
 
-  public EmptyTypeFilename() {}
+  public EmptyTypeFilename() {
+    // Do nothing
+  }
 
   @Override
   public String getDefaultFileExtension() {

core/src/main/java/org/apache/hop/core/gui/plugin/toolbar/EmptyTypeMetadata.java

@@ -22,7 +22,9 @@
 
 public class EmptyTypeMetadata implements ITypeMetadata {
 
-  public EmptyTypeMetadata() {}
+  public EmptyTypeMetadata() {
+    // Do nothing
+  }
 
   @Override
   public Class<? extends IHopMetadata> getMetadataClass() {

core/src/main/java/org/apache/hop/core/logging/HopLogLayout.java

@@ -97,7 +97,9 @@ public boolean ignoresThrowable() {
     return false;
   }
 
-  public void activateOptions() {}
+  public void activateOptions() {
+    // Do nothing
+  }
 
   public boolean isTimeAdded() {
     return timeAdded;

core/src/main/java/org/apache/hop/core/logging/LoggingBuffer.java

@@ -144,7 +144,9 @@ public StringBuffer getBuffer() {
     return getBuffer(null, true);
   }
 
-  public void close() {}
+  public void close() {
+    // Do nothing
+  }
 
   public void doAppend(HopLoggingEvent event) {
     if (event.getMessage() instanceof LogMessage) {

core/src/main/java/org/apache/hop/core/logging/LoggingPluginType.java

@@ -75,7 +75,9 @@ protected boolean extractSeparateClassLoader(LoggingPlugin annotation) {
 
   @Override
   protected void addExtraClasses(
-      Map<Class<?>, String> classMap, Class<?> clazz, LoggingPlugin annotation) {}
+      Map<Class<?>, String> classMap, Class<?> clazz, LoggingPlugin annotation) {
+    // Do nothing
+  }
 
   @Override
   protected String extractDocumentationUrl(LoggingPlugin annotation) {

core/src/main/java/org/apache/hop/core/logging/Metrics.java

@@ -19,6 +19,7 @@
 
 import org.apache.hop.core.metrics.MetricsSnapshotType;
 
+@SuppressWarnings("java:S1104")
 public class Metrics implements IMetrics {
 
   // Database

core/src/main/java/org/apache/hop/core/logging/Slf4jLoggingEventListener.java

@@ -46,7 +46,9 @@ public class Slf4jLoggingEventListener implements IHopLoggingEventListener {
 
   private static final String SEPARATOR = "/";
 
-  public Slf4jLoggingEventListener() {}
+  public Slf4jLoggingEventListener() {
+    // Do nothing
+  }
 
   @Override
   public void eventAdded(HopLoggingEvent event) {

core/src/main/java/org/apache/hop/core/parameters/NamedParameters.java

@@ -31,7 +31,9 @@ public class NamedParameters implements INamedParameters {
   protected Map<String, NamedParameter> params = new HashMap<>();
 
   /** Default constructor. */
-  public NamedParameters() {}
+  public NamedParameters() {
+    // Do nothing
+  }
 
   @Override
   public void addParameterDefinition(String key, String defValue, String description)

core/src/main/java/org/apache/hop/core/parameters/NamedParametersDefnitions.java

@@ -28,7 +28,9 @@ public class NamedParametersDefnitions implements INamedParameterDefinitions {
   protected Map<String, NamedParameterDefinition> params = new HashMap<>();
 
   /** Default constructor. */
-  public NamedParametersDefnitions() {}
+  public NamedParametersDefnitions() {
+    // Do nothing
+  }
 
   @Override
   public void addParameterDefinition(String key, String defValue, String description)

core/src/main/java/org/apache/hop/core/plugins/BaseFragmentType.java

@@ -100,7 +100,9 @@ protected boolean extractSeparateClassLoader(T annotation) {
   }
 
   @Override
-  protected void addExtraClasses(Map<Class<?>, String> classMap, Class<?> clazz, T annotation) {}
+  protected void addExtraClasses(Map<Class<?>, String> classMap, Class<?> clazz, T annotation) {
+    // Do nothing
+  }
 
   protected abstract class FragmentTypeListener implements IPluginTypeListener {
     private final PluginRegistry registry;

core/src/main/java/org/apache/hop/core/plugins/BasePluginType.java

@@ -550,7 +550,9 @@ protected boolean extractincludeJdbcDrivers(T annotation) {
     return false;
   }
 
-  protected void addExtraClasses(Map<Class<?>, String> classMap, Class<?> clazz, T annotation) {}
+  protected void addExtraClasses(Map<Class<?>, String> classMap, Class<?> clazz, T annotation) {
+    // Do nothing
+  }
 
   protected String extractDocumentationUrl(T annotation) {
     return null;

core/src/main/java/org/apache/hop/core/row/IValueMeta.java

@@ -1367,7 +1367,9 @@ String getDatabaseColumnTypeDefinition(
   void loadMetaFromJson(JSONObject jValue);
 
   class ValueMetaHopMetadataObjectFactory implements IHopMetadataObjectFactory {
-    public ValueMetaHopMetadataObjectFactory() {}
+    public ValueMetaHopMetadataObjectFactory() {
+      // Do nothing
+    }
 
     @Override
     public Object createObject(String id, Object parentObject) throws HopException {

core/src/main/java/org/apache/hop/core/row/value/ValueMetaPluginType.java

@@ -73,7 +73,9 @@ protected boolean extractSeparateClassLoader(ValueMetaPlugin annotation) {
 
   @Override
   protected void addExtraClasses(
-      Map<Class<?>, String> classMap, Class<?> clazz, ValueMetaPlugin annotation) {}
+      Map<Class<?>, String> classMap, Class<?> clazz, ValueMetaPlugin annotation) {
+    // Do nothing
+  }
 
   @Override
   protected String extractDocumentationUrl(ValueMetaPlugin annotation) {

core/src/main/java/org/apache/hop/core/search/SearchableAnalyserPluginType.java

@@ -75,7 +75,9 @@ protected boolean extractSeparateClassLoader(SearchableAnalyserPlugin annotation
 
   @Override
   protected void addExtraClasses(
-      Map<Class<?>, String> classMap, Class<?> clazz, SearchableAnalyserPlugin annotation) {}
+      Map<Class<?>, String> classMap, Class<?> clazz, SearchableAnalyserPlugin annotation) {
+    // Do nothing
+  }
 
   @Override
   protected String extractDocumentationUrl(SearchableAnalyserPlugin annotation) {

core/src/main/java/org/apache/hop/core/util/HttpClientManager.java

@@ -270,9 +270,13 @@ public java.security.cert.X509Certificate[] getAcceptedIssuers() {
               return null;
             }
 
-            public void checkClientTrusted(X509Certificate[] certs, String authType) {}
+            public void checkClientTrusted(X509Certificate[] certs, String authType) {
+              // Do nothing
+            }
 
-            public void checkServerTrusted(X509Certificate[] certs, String authType) {}
+            public void checkServerTrusted(X509Certificate[] certs, String authType) {
+              // Do nothing
+            }
           }
         };
 

core/src/main/java/org/apache/hop/core/util/SortedFileOutputStream.java

@@ -80,7 +80,9 @@ public void write(int b) throws IOException {
 
   /** Catch <code>flush</code> method, don't do nothing */
   @Override
-  public void flush() throws IOException {}
+  public void flush() throws IOException {
+    // Do nothing
+  }
 
   /**
    * If internally stored content is available, sorting keys of content, then sending content to

core/src/main/java/org/apache/hop/core/vfs/plugin/VfsPluginType.java

@@ -75,7 +75,9 @@ protected boolean extractSeparateClassLoader(VfsPlugin annotation) {
 
   @Override
   protected void addExtraClasses(
-      Map<Class<?>, String> classMap, Class<?> clazz, VfsPlugin annotation) {}
+      Map<Class<?>, String> classMap, Class<?> clazz, VfsPlugin annotation) {
+    // Do nothing
+  }
 
   @Override
   protected String extractDocumentationUrl(VfsPlugin annotation) {

core/src/main/java/org/apache/hop/i18n/GlobalMessages.java

@@ -84,7 +84,9 @@ public class GlobalMessages extends AbstractMessageHandler {
    * TODO: extend from abstract class to ensure singleton status and migrate instantiation to class
    * controlled private
    */
-  public GlobalMessages() {}
+  public GlobalMessages() {
+    // Do nothing
+  }
 
   public static synchronized IMessageHandler getInstance() {
     if (GMinstance == null) {

core/src/main/java/org/apache/hop/metadata/plugin/MetadataPluginType.java

@@ -78,7 +78,9 @@ protected boolean extractSeparateClassLoader(HopMetadata annotation) {
 
   @Override
   protected void addExtraClasses(
-      Map<Class<?>, String> classMap, Class<?> clazz, HopMetadata annotation) {}
+      Map<Class<?>, String> classMap, Class<?> clazz, HopMetadata annotation) {
+    // Do Nothing
+  }
 
   @Override
   protected String extractDocumentationUrl(HopMetadata annotation) {

core/src/main/java/org/apache/hop/server/ServerConnectionManager.java

@@ -80,7 +80,9 @@ private static X509TrustManager getDefaultTrustManager() {
     return new X509TrustManager() {
       @Override
       public void checkClientTrusted(X509Certificate[] certs, String param)
-          throws CertificateException {}
+          throws CertificateException {
+        // Do nothing
+      }
 
       @Override
       public void checkServerTrusted(X509Certificate[] certs, String param)

core/src/test/java/org/apache/hop/core/database/DatabaseTest.java

@@ -58,7 +58,6 @@
 import org.apache.hop.core.variables.IVariables;
 import org.apache.hop.core.variables.Variables;
 import org.apache.hop.junit.rules.RestoreHopEnvironment;
-import org.junit.After;
 import org.junit.Before;
 import org.junit.BeforeClass;
 import org.junit.ClassRule;
@@ -106,9 +105,6 @@ public void setUp() throws Exception {
     variables = new Variables();
   }
 
-  @After
-  public void tearDown() {}
-
   @Test
   public void testGetQueryFieldsFromDatabaseMetaData() throws Exception {
     DatabaseMeta meta = mock(DatabaseMeta.class);

core/src/test/java/org/apache/hop/core/parameters/DuplicateParamExceptionTest.java

@@ -28,7 +28,9 @@ public class DuplicateParamExceptionTest {
   DuplicateParamException exception;
 
   @Before
-  public void setUp() throws Exception {}
+  public void setUp() throws Exception {
+    // Do nothing
+  }
 
   @Test
   public void testConstructors() {