Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug #3994 Issue with tests in hop-plugins-misc-git on Windows #4220

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

gvdutra
Copy link
Contributor

@gvdutra gvdutra commented Aug 19, 2024

I made a change if it is windows OS try to delete the tmp folder manually. otherwise keep the same behaviour.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@gvdutra gvdutra requested a review from hansva August 19, 2024 07:33
@gvdutra gvdutra closed this Aug 19, 2024
@gvdutra gvdutra reopened this Aug 19, 2024
@gvdutra gvdutra force-pushed the 3994 branch 3 times, most recently from 11a008d to 5a1503a Compare August 20, 2024 06:17
@hansva hansva merged commit c91eda4 into apache:main Aug 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants