Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Cleanup XML of action Ping #1985 #4242

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

gvdutra
Copy link
Contributor

@gvdutra gvdutra commented Aug 24, 2024

I made the cleanup for Ping action.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@gvdutra gvdutra requested a review from hansva August 24, 2024 19:12
@hansva
Copy link
Contributor

hansva commented Aug 26, 2024

oh boy, let's see how we handle this one... it seems nbr_packets should be the correct one and not nbrPackets but nbrPackets was used for a short period as an XML key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants