Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup XML of transform Execute Tests #2008 #4306

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

nadment
Copy link
Contributor

@nadment nadment commented Sep 9, 2024

No description provided.

Copy link
Contributor

@bamaer bamaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did a couple of manual tests and ran all the transform integration tests without any issues.

throw new HopXmlException("Unable to load execute test transform details", e);
}
}

@Override
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the getDialogClassname method isn't required any longer, could be removed.

Remove the getDialogClassName method isn't required any longer
@bamaer bamaer merged commit 59eadc6 into apache:main Sep 19, 2024
3 checks passed
@github-actions github-actions bot removed this from the 2.10 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Cleanup XML of transform Execute Tests
2 participants