Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4321 - Cannot delete folders with Azure Multiaccount authentication #4323

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

xdelox
Copy link

@xdelox xdelox commented Sep 16, 2024

Fixes #4321


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added this IT for the sake of testing locally, I knew these ITs are temporarily disabled

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this second argument, this override of the method is able to resolve custom namespaces for picking the right Filesystem provider.
I see @hansva used it all around, instead of the previous version. However I wonder if we should consider to deprecate the old method, which looks the same, for the rest.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are spots where that's not possible because of chicken-egg for example loading the project and metadata can also be done via VFS but can't use the custom locations

@hansva hansva merged commit 7ce90d1 into apache:main Sep 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Delete folders Action doesn't actually delete folders on Azure
2 participants