feat: add docs for compaction offload mechanism #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failed, please execute |
jiacai2050
reviewed
Oct 24, 2024
| 4. Compaction node executes the task and send the result back to the HoraeDB. | ||
| 5. HoraeDB receives the result and updates the manifest. | ||
|
|
||
| We can see that the compaction offload architecture in HoraeDB is different from the traditional one. It separates the compaction task distribution from HoraeMeta and moves it into HoraeDB, which reduces the load of HoraeMeta to lower the risk of single points of failure. |
There was a problem hiding this comment.
We can see that the compaction offload architecture in HoraeDB is different from the traditional one.
I think most system will do like this, only the horaedb node know which sst it has, the meta have no idea how many sst a table contains, so meta can't the schedule task.
There was a problem hiding this comment.
Thanks @jiacai2050 . The statement here is indeed incorrect.
fixed.
jiacai2050
reviewed
Oct 24, 2024
| │ HoraeMeta Cluster │ | ||
| │ │ | ||
| └───────────────────────────────────────────────────────────────────────┘ | ||
| ▲ ▲ | | |
There was a problem hiding this comment.
We need to add sequence number to illustrate how the process will go.
Like the first image in rocksdb: https://github.com/facebook/rocksdb/wiki/Remote-Compaction-(Experimental)
jiacai2050
reviewed
Oct 28, 2024
jiacai2050
reviewed
Oct 28, 2024
jiacai2050
reviewed
Oct 28, 2024
jiacai2050
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
Add tech-design doc for compaction offloading.