Skip to content

Commit

Permalink
remove comments
Browse files Browse the repository at this point in the history
  • Loading branch information
zealchen committed Mar 11, 2024
1 parent 260ac72 commit 76e6007
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 7 deletions.
2 changes: 1 addition & 1 deletion src/components/parquet_ext/src/prune/min_max.rs
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ fn filter_row_groups_inner(

fn logical2physical(expr: &Expr, schema: &ArrowSchema, execution_props: &ExecutionProps) -> DataFusionResult<Arc<dyn PhysicalExpr>> {
schema.clone().to_dfschema().and_then(|df_schema| {
create_physical_expr(expr, &df_schema, schema, &execution_props)
create_physical_expr(expr, &df_schema, schema, execution_props)
})
}

Expand Down
4 changes: 0 additions & 4 deletions src/components/tracing_util/src/logging.rs
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,6 @@ pub fn init_tracing_with_file(config: &Config, node_addr: &str, rotation: Rotati
.with_span_events(FmtSpan::ENTER | FmtSpan::CLOSE);

let subscriber = Registry::default().with(f_layer);
// TODO: subscriber.with(layer1) has the different type with
// subscriber.with(layer1).with(layer2)...
// So left some duplicated codes here. Maybe we can use marco to simplify
// it.
match &config.console {
Some(console) => {
let console_addr = format!("{}:{}", node_addr, console.port);
Expand Down
2 changes: 0 additions & 2 deletions src/table_engine/src/partition/rule/key.rs
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,6 @@ fn expand_partition_keys_group<'a>(
for filter_idx in group {
let filter = &filters[*filter_idx];
let datums = match &filter.condition {
// Only `Eq` is supported now.
// TODO: to support `In`'s extracting.
PartitionCondition::Eq(datum) => vec![datum.as_view()],
PartitionCondition::In(datums) => datums.iter().map(Datum::as_view).collect_vec(),
_ => {
Expand Down

0 comments on commit 76e6007

Please sign in to comment.