fix wrong data type size

apache · Aug 18, 2022 · 7cd4f9a · 7cd4f9a
1 parent 97fa3e2
commit 7cd4f9a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/common_types/src/datum.rs b/common_types/src/datum.rs
@@ -180,10 +180,10 @@ impl DatumKind {
     /// Return None for variable-length type
     pub fn size(&self) -> Option<usize> {
         let size = match self {
-            DatumKind::Null => 1,
+            DatumKind::Null => 0,
             DatumKind::Timestamp => 8,
             DatumKind::Double => 8,
-            DatumKind::Float => 8,
+            DatumKind::Float => 4,
             DatumKind::Varbinary => return None,
             DatumKind::String => return None,
             DatumKind::UInt64 => 8,

diff --git a/common_types/src/schema.rs b/common_types/src/schema.rs
@@ -630,8 +630,9 @@ impl Schema {
         self.timestamp_index
     }
 
-    /// Whether i-nth column is key column
-    /// TODO: should tag column be key columns?
+    /// Whether i-nth column is non-key column
+    ///
+    /// Non-key means not timestamp/tag/primary key
     pub fn non_key_column(&self, i: usize) -> bool {
         if self.column(i).is_tag {
             return false;