Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use varint to encode string/bytes length in memtable #1055

Closed
ShiKaiWi opened this issue Jul 7, 2023 · 0 comments · Fixed by #1060
Closed

Use varint to encode string/bytes length in memtable #1055

ShiKaiWi opened this issue Jul 7, 2023 · 0 comments · Fixed by #1060
Assignees
@baojinri
Labels
feature New feature or request

Comments

@ShiKaiWi
Copy link
Member

ShiKaiWi commented Jul 7, 2023

Describe This Problem

Currently, we use u32 to encode the string/bytes in the memtable, leading to much encoding overhead for small string or bytes.

Proposal

Use varint for the encoding of length.

Additional Context

No response
@ShiKaiWi ShiKaiWi added the feature New feature or request label Jul 7, 2023
@baojinri baojinri self-assigned this Jul 7, 2023
@baojinri baojinri mentioned this issue Jul 10, 2023
Merged
ShiKaiWi pushed a commit that referenced this issue Jul 11, 2023
@baojinri
refactor: use varint to encode string/bytes length (#1060)
8afb0b1 
## Rationale
close #1055

## Detailed Changes
- use varint to encode length of string/bytes in memtable

## Test Plan
- Existing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baojinri baojinri

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: use varint to encode string/bytes length baojinri/ceresdb
2 participants
@ShiKaiWi @baojinri