Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ignore interceptor in integration test framework #107

Closed
waynexia opened this issue Jul 19, 2022 · 1 comment · Fixed by #270
Closed

Implement ignore interceptor in integration test framework #107

waynexia opened this issue Jul 19, 2022 · 1 comment · Fixed by #270
Labels
A-test Area: Unit or integration test cases, or test framework feature New feature or request

Comments

@waynexia
Copy link
Member

waynexia commented Jul 19, 2022

Description

Some cases are not expected to run due to unstable features, temporary changes or anything else. It should be supported to just ignore them.

Proposal

Implement the ignore interceptor. Proposed syntax:

-- CERESDB ignore: REASON

Follows the K-V format. Value for this interceptor is the reason why this case got ignored. It won't take effort and is a comment in fact.

Additional context

TBD: should we count/record those ignored cases and report it in the end?
ref #154

@waynexia waynexia added the feature New feature or request label Jul 19, 2022
@waynexia waynexia modified the milestone: Release v0.2 Jul 19, 2022
@waynexia waynexia added the A-test Area: Unit or integration test cases, or test framework label Jul 20, 2022
@ShiKaiWi
Copy link
Member

ShiKaiWi commented Sep 26, 2022

Actually, there is nothing random in the sequential write/read procedure for now. Besides this, it is a good feature for any tests to keep the determined results.

So I think we should fix these random things rather than support the proposed the ignore interceptor.

And I find out it that the random table id results from that fact the data generated by the previous run is not reset, so the id for the created-dropped-created-again table will be incremented finally, which leads to the test failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-test Area: Unit or integration test cases, or test framework feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants