Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor parsing sql comment #158

Closed
chunshao90 opened this issue Jul 28, 2022 · 0 comments · Fixed by #167
Closed

Refactor parsing sql comment #158

chunshao90 opened this issue Jul 28, 2022 · 0 comments · Fixed by #167
Assignees
@baojinri
Labels
A-SQL Area: SQL layer feature New feature or request

Comments

@chunshao90
Copy link
Contributor

chunshao90 commented Jul 28, 2022 •
edited by Rachelint
Loading

Description

Replace ColumnOption::DialectSpecific with ColumnOption::Comment to parse sql comment.

Proposal

ref: https://github.com/CeresDB/ceresdb/blob/8d1472a33054ac7f92cc957a30f1a83e6da005f6/sql/src/parser.rs#L476

Additional context
ref #154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baojinri baojinri

Labels
A-SQL Area: SQL layer feature New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@chunshao90 @baojinri