Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the exist wal interface to adapt the new design #283

Closed
Rachelint opened this issue Oct 8, 2022 · 0 comments · Fixed by #288
Closed

Modify the exist wal interface to adapt the new design #283

Rachelint opened this issue Oct 8, 2022 · 0 comments · Fixed by #288

Comments

@Rachelint
Copy link
Contributor

Rachelint commented Oct 8, 2022

Description
Now the wal interface's design is for the mapping one table to one region (wal unit). For adapting to the new wal implementation based on kafka and solving some exist problem (for example, replay is too slow), we plan to modify the wal interface.

Proposal

  • Make region id to WalLocation (include region id and table id now).
  • Try best to keep current process in other modules (in fact, I prefer to add new components for avoiding direct interacting between Instance and WalManager to keep current process in later development).
  • Add a new method scan to WalManager(implement it in wal on kafka firstly, other implementations will implement and make use of it after).

Additional context

@Rachelint Rachelint moved this from Todo to In Progress in Wal on kafka Oct 8, 2022
Repository owner moved this from In Progress to Done in Wal on kafka Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant