feat: use instead forked rskafka to support limited retry
#1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
force-pushed
the
use-the-instead-forked-rskafka
branch
from
b31ee26 to
d54f4c9
Compare
Rachelint
force-pushed
the
use-the-instead-forked-rskafka
branch
from
d54f4c9 to
c590027
Compare
dust1
pushed a commit
to dust1/ceresdb
that referenced
this pull request
Aug 9, 2023
) ## Rationale Part of apache#799 We use `rskafka` as our kafka client. However I found it will retry without limit even though kafka service is unavailable... (see [https://github.com/influxdata/rskafka/issues/65](https://github.com/influxdata/rskafka/issues/65)) Worse, I found `rskafka` is almostis no longer maintained... For quick fix, I forked it to support limited retry. ## Detailed Changes + Use the instead forked `rskafka`(supporting limited retry). + Add more logs in recovery path for better debugging. ## Test Plan Test manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Part of #799
We use
rskafkaas our kafka client.However I found it will retry without limit even though kafka service is unavailable...
(see influxdata/rskafka#65)
Worse, I found
rskafkais almostis no longer maintained...For quick fix, I forked it to support limited retry.
Detailed Changes
rskafka(supporting limited retry).Test Plan
Test manually.