Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sql support dictionary column #1049

Merged
merged 70 commits into from
Jul 5, 2023
Merged

feat: sql support dictionary column #1049

merged 70 commits into from
Jul 5, 2023

Conversation

tanruixiang
Copy link
Member

@tanruixiang tanruixiang commented Jul 5, 2023 •
edited by jiacai2050
Loading

Rationale

Close #965 #1050

Detailed Changes

Test Plan

CI

tanruixiang and others added 30 commits June 13, 2023 19:45
@tanruixiang
draft
d612b0e
@tanruixiang
draft
7a5e617
@tanruixiang
add builder testcase
c0bb71c
@tanruixiang
dictionary builder complete
9b60d2b
@tanruixiang
fmt
9433827
@tanruixiang
complete write process
a55acd1
@tanruixiang
draft
56ea056
@tanruixiang
draft
1848b8a
@tanruixiang
draft
b4c3535
@tanruixiang
fmt
48436d9
@tanruixiang
delete debug print
526dec9
@tanruixiang
Merge branch 'main' into support_dictionary
123a3c0
@tanruixiang
adjust ut and delete debug display print
326251b
@tanruixiang
hard code:replace is_dictionary with is_tag just for test, need to re…
eb9b616 
…vert
@tanruixiang
fix convert bug
5907560
@tanruixiang
fix bug
929124c
@tanruixiang
resotre info level
2141b40
@tanruixiang
support get ScalarValue from dictionary type
c8f7c81
@tanruixiang
Revert "hard code:replace is_dictionary with is_tag just for test, ne…
cfc6d12 
…ed to revert"

This reverts commit eb9b616.
@tanruixiang
support is_dictionary in sql
d83fecf
@tanruixiang
add is_dictionary schema parse
30424bd
@tanruixiang
revert log level
54521bc
@tanruixiang
Revert "revert log level"
1364b78 
This reverts commit 54521bc.
@tanruixiang
Revert "add is_dictionary schema parse"
3666a26 
This reverts commit 30424bd.
@tanruixiang
Revert "support is_dictionary in sql"
df5b49b 
This reverts commit d83fecf.
@tanruixiang
Revert "Revert "hard code:replace is_dictionary with is_tag just for …
eb12365 
…test, need to revert""

This reverts commit cfc6d12.
@tanruixiang
Revert "support get ScalarValue from dictionary type"
c32ebd1 
This reverts commit c8f7c81.
@tanruixiang
Revert "resotre info level"
663fba4 
This reverts commit 2141b40.
@tanruixiang
Revert "fix bug"
249e259 
This reverts commit 929124c.
@tanruixiang
Revert "fix convert bug"
0b4ed48 
This reverts commit 5907560.
@tanruixiang tanruixiang changed the title Client support dictionary feat: sql support dictionary column Jul 5, 2023
jiacai2050
jiacai2050 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 65b133e into apache:main Jul 5, 2023
@tanruixiang tanruixiang deleted the client_support_dictionary branch July 5, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use dictionary type to store tags column
3 participants
@tanruixiang @jiacai2050 @ShiKaiWi