Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add record batch mem stats #1058

Merged
merged 11 commits into from
Jul 11, 2023
Merged

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Jul 7, 2023

Rationale

When some metrics contains more than one subtask, it's helpful to collect them together for output.

Detailed Changes

  • Update metric macro, add metric operator.

Test Plan

Update basic UT to test this. This is what I get in my test env:

# Before
        scan_sst_6655:                                                                                                                                                                            
            project_record_batch=847.03µs                                                                                                                                                         
            project_record_batch=1.182922ms                                                                                                                                                       
            project_record_batch=1.208636ms                                                                                                                                                       
            project_record_batch=1.246589ms                                                                                                                                                       
            project_record_batch=1.296161ms                                                                                                                                                       
            project_record_batch=1.323357ms                                                                                                                                                       
            project_record_batch=1.4293ms                                                                                                                                                                      

# After
        scan_sst_6655:                                                                                                                                                                            
            project_record_batch=10.170503ms 

@jiacai2050 jiacai2050 requested a review from ShiKaiWi July 10, 2023 06:50
@jiacai2050 jiacai2050 marked this pull request as ready for review July 10, 2023 06:51
components/trace_metric/src/metric.rs Outdated Show resolved Hide resolved
components/trace_metric/src/metric.rs Outdated Show resolved Hide resolved
components/trace_metric_derive/src/builder.rs Outdated Show resolved Hide resolved
jiacai2050 and others added 3 commits July 11, 2023 10:09
Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit aa00ef2 into apache:main Jul 11, 2023
@jiacai2050 jiacai2050 deleted the benchmark-20230705 branch July 11, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants