Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix fully flushed region open in kakfa wal #1061

Merged
merged 1 commit into from
Jul 11, 2023
Merged

fix: fix fully flushed region open in kakfa wal #1061

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 43 additions & 5 deletions wal/src/message_queue_impl/region.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,17 @@ impl<M: MessageQueue> Region<M> {
namespace, region_id
);

// Fetch high watermark and check.
// Fetch earliest, high watermark and check.
let earliest = message_queue
.fetch_offset(meta_topic, OffsetType::EarliestOffset)
.await
.box_err()
.context(OpenWithCause {
namespace,
region_id,
msg: "failed while recover from meta",
})?;

let high_watermark = message_queue
.fetch_offset(meta_topic, OffsetType::HighWaterMark)
.await
Expand All @@ -235,9 +245,19 @@ impl<M: MessageQueue> Region<M> {
msg: "failed while recover from meta",
})?;

if high_watermark == 0 {
debug!("Meta topic is empty, it just needs to recover from log topic, namespace:{}, region id:{}", namespace, region_id);
return Ok(None);
if earliest == high_watermark {
if high_watermark == 0 {
info!("Recover region meta from meta, found empty meta topic, just need to recover from log topic, namespace:{}, region id:{}",
namespace, region_id);
return Ok(None);
}

return OpenNoCause {
namespace,
region_id,
msg: "region meta impossible to be empty when having written logs",
}
.fail();
}

// Fetch snapshot from meta topic(just fetch the last snapshot).
Expand Down Expand Up @@ -313,6 +333,9 @@ impl<M: MessageQueue> Region<M> {
});

let region_safe_delete_offset = if min_safe_delete_offset == i64::MAX {
info!("Recover region meta from meta, min_safe_delete_offset not exist, region_meta_snapshot:{:?}, namespace:{}, region id:{}",
value, namespace, region_id);

None
} else {
Some(min_safe_delete_offset)
Expand Down Expand Up @@ -352,6 +375,17 @@ impl<M: MessageQueue> Region<M> {
// FIXME: should not judge whether topic is empty or not by caller.
// The consumer iterator should return immediately rather than hanging when
// topic empty.
// Fetch earliest, high watermark and check.
let earliest = message_queue
.fetch_offset(log_topic, OffsetType::EarliestOffset)
.await
.box_err()
.context(OpenWithCause {
namespace,
region_id,
msg: "failed while recover from log",
})?;

let high_watermark = message_queue
.fetch_offset(log_topic, OffsetType::HighWaterMark)
.await
Expand All @@ -361,7 +395,11 @@ impl<M: MessageQueue> Region<M> {
region_id,
msg: "failed while recover from log",
})?;
if high_watermark == 0 {

if earliest == high_watermark {
info!("Recover region meta from log, found empty log topic, namespace:{}, region_id:{}, earliest:{}, high_watermark:{}",
namespace, region_id, earliest, high_watermark
);
return Ok(());
}

Expand Down