Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong encoding when write schema is different #1103

Merged
merged 2 commits into from
Jul 25, 2023
Merged

fix: wrong encoding when write schema is different #1103

merged 2 commits into from
Jul 25, 2023

Conversation

ShiKaiWi
Copy link
Member

@ShiKaiWi ShiKaiWi commented Jul 24, 2023 •
edited
Loading

Rationale

Close #1097

The row encoding will be wrong when processing null columns which is caused by a different write schema from the logical table schema.

Detailed Changes

  • Set the correct column index for the null bit sets in the row's encoding

Test Plan

Add a new designed test for different write schema.

@ShiKaiWi ShiKaiWi mentioned this pull request Jul 24, 2023
Closed
@ShiKaiWi ShiKaiWi marked this pull request as ready for review July 24, 2023 16:34
baojinri
baojinri approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@baojinri baojinri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baojinri baojinri merged commit 4f37dbf into apache:main Jul 25, 2023
@ShiKaiWi ShiKaiWi deleted the fix-1097 branch July 25, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baojinri baojinri baojinri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Row decode out of range
2 participants
@ShiKaiWi @baojinri