Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove the codes about the reverse reading #1116

Merged
merged 3 commits into from
Aug 1, 2023

Conversation

ShiKaiWi
Copy link
Member

@ShiKaiWi ShiKaiWi commented Jul 28, 2023

Rationale

Currently, the read in a reverse order of primary key is not supported yet. Remove the codes about that.

Detailed Changes

Remove the codes about the reverse read during plan stage and reading sst stage, while the ability to scan memtable in reverse order is kept for possible future use.

Test Plan

Existing tests.

Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit ee10f2f into apache:main Aug 1, 2023
@ShiKaiWi ShiKaiWi deleted the fix-remove-reverse-scan branch August 1, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants