refactor: refactor query engine #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
force-pushed
the
refactor-the-query-engine
branch
from
8599043 to
b73eefc
Compare
Rachelint
force-pushed
the
refactor-the-query-engine
branch
from
d18bbf2 to
b0536b8
Compare
|
It's strange that even though I retried CI, it still skipped the unit test. |
tanruixiang
changed the title
|
@Rachelint This PR looks good to me. Let's merge it after the ci is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Close #1136
Part of #1112
The query engine impl now is too messy, you can #1136 . Worse, it can't support physical plan's remote execution, which is necessary for #1112.
In this pr, I refactor it for solving problems mentioned above.
Detailed Changes
physical planandphysical planner's trait definition and impl.physical plan's creation and execution.Test Plan
Test by exist tests.