Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support PostgreSQL wire protocol #1138

Merged
merged 3 commits into from
Aug 8, 2023
Merged

feat: support PostgreSQL wire protocol #1138

merged 3 commits into from
Aug 8, 2023

Conversation

holicc
Copy link
Contributor

@holicc holicc commented Aug 6, 2023 •
edited by jiacai2050
Loading

Rationale

close #711

I have to create a new PR again, because the old branch name is not valid for sdk-testing.

Detailed Changes

support PostgreSQL wire Protocol

Test Plan

Integration tests

@holicc holicc changed the title Postgresql protocol feat: PostgreSQL wire protocol Aug 7, 2023
@tanruixiang
Copy link
Member

Hi, After #1134, the apache template has changed. I updated the conflict for you so as not to confuse you.

@holicc
Copy link
Contributor Author

holicc commented Aug 7, 2023

@tanruixiang Hi, the CI/unit-test doesn't have enough device space. I'm not sure if the problem is with my code or the CI, but I can pass the test on my laptop. Can you help me fix this error?

IO error: No space left on device: While appending to file: /tmp/.tmp2FtmjK/wal/000004.dbtmp.plain: No space left on device

@tanruixiang
Copy link
Member

@tanruixiang Hi, the CI/unit-test doesn't have enough device space. I'm not sure if the problem is with my code or the CI, but I can pass the test on my laptop. Can you help me fix this error?

IO error: No space left on device: While appending to file: /tmp/.tmp2FtmjK/wal/000004.dbtmp.plain: No space left on device

Don't worry, it's not a problem with your code, I'll re-run it and try.

@tanruixiang tanruixiang changed the title feat: PostgreSQL wire protocol feat: support PostgreSQL wire protocol Aug 7, 2023
jiacai2050
jiacai2050 reviewed Aug 7, 2023
View reviewed changes
server/src/postgresql/error.rs Outdated Show resolved Hide resolved
server/src/postgresql/handler.rs Outdated Show resolved Hide resolved
server/src/postgresql/handler.rs Show resolved Hide resolved
jiacai2050
jiacai2050 approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 2bfcd42 into apache:main Aug 8, 2023
@jiacai2050
Copy link
Contributor

Thanks, Welcome to CeresDB community 🚀

@sunng87
Copy link
Contributor

sunng87 commented Aug 10, 2023

Nice to see see pgwire inclusion in ceresdb. Please kindly let me know if you find anything need to change/improve.

@jiacai2050
Copy link
Contributor

Thanks for your hard work on pgwire. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support PostgreSQL wire protocol
4 participants
@holicc @tanruixiang @jiacai2050 @sunng87