refactor: add support_pushdown in table trait

analytic_engine/src/table/mod.rs

@@ -401,6 +401,17 @@ impl TableImpl {
     }
 }
 
+pub fn support_pushdown(schema: &Schema, need_dedup: bool, col_names: &[String]) -> bool {
+    if !need_dedup {
+        return true;
+    }
+
+    // When table need dedup, only unique keys columns support pushdown
+    col_names
+        .iter()
+        .all(|col_name| schema.is_unique_column(col_name.as_str()))
+}
+
 #[async_trait]
 impl Table for TableImpl {
     fn name(&self) -> &str {
@@ -431,6 +442,12 @@ impl Table for TableImpl {
         self.table_data.metrics.table_stats()
     }
 
+    fn support_pushdown(&self, read_schema: &Schema, col_names: &[String]) -> bool {
+        let need_dedup = self.table_data.table_options().need_dedup();
+
+        support_pushdown(read_schema, need_dedup, col_names)
+    }
+
     async fn write(&self, request: WriteRequest) -> Result<usize> {
         let _timer = self.table_data.metrics.start_table_total_timer();
 

analytic_engine/src/table_options.rs

@@ -412,6 +412,11 @@ pub struct TableOptions {
 }
 
 impl TableOptions {
+    pub fn from_map(map: &HashMap<String, String>, is_create: bool) -> Result<Self> {
+        let opt = Self::default();
+        merge_table_options(map, &opt, is_create)
+    }
+
     #[inline]
     pub fn segment_duration(&self) -> Option<Duration> {
         self.segment_duration.map(|v| v.0)
@@ -712,7 +717,11 @@ fn merge_table_options(
     let mut table_opts = table_old_opts.clone();
     if is_create {
         if let Some(v) = options.get(SEGMENT_DURATION) {
-            table_opts.segment_duration = Some(parse_duration(v).context(ParseDuration)?);
+            if v.is_empty() {
+                table_opts.segment_duration = None;
+            } else {
+                table_opts.segment_duration = Some(parse_duration(v).context(ParseDuration)?);
+            }
         }
         if let Some(v) = options.get(UPDATE_MODE) {
             table_opts.update_mode = UpdateMode::parse_from(v)?;

common_types/src/schema.rs

@@ -884,34 +884,26 @@ impl Schema {
         }
     }
 
-    pub fn unique_keys(&self) -> Vec<&str> {
-        // Only filters on the columns belonging to the unique key can be pushed down.
-        if self.tsid_column().is_some() {
-            // When tsid exists, that means default primary key (tsid, timestamp) is used.
-            // So, all filters of tag columns(tsid is the hash result of all tags),
-            // timestamp key and tsid can be pushed down.
-            let mut keys = self
-                .columns()
-                .iter()
-                .filter_map(|column| {
-                    if column.is_tag {
-                        Some(column.name.as_str())
-                    } else {
-                        None
-                    }
-                })
-                .collect::<Vec<_>>();
-            keys.extend([&self.tsid_column().unwrap().name, self.timestamp_name()]);
+    pub fn is_unique_column(&self, col_name: &str) -> bool {
+        // primary key is obvious unique.
+        let is_primary_key = self
+            .primary_key_indexes()
+            .iter()
+            .map(|key_idx| self.column(*key_idx).name.as_str())
+            .any(|primary_key| primary_key == col_name);
 
-            keys
-        } else {
-            // When tsid does not exist, that means user defined primary key is used.
-            // So, only filters of primary key can be pushed down.
-            self.primary_key_indexes()
-                .iter()
-                .map(|key_idx| self.column(*key_idx).name.as_str())
-                .collect()
+        if is_primary_key {
+            return true;
         }
+
+        if self.tsid_column().is_none() {
+            return false;
+        }
+
+        // When tsid exists, it means tag column is also unique.
+        self.columns()
+            .iter()
+            .any(|column| column.is_tag && column.name == col_name)
     }
 
     /// Panic if projection is invalid.

partition_table_engine/Cargo.toml

@@ -25,6 +25,7 @@ workspace = true
 workspace = true
 
 [dependencies]
+analytic_engine = { workspace = true }
 async-trait = { workspace = true }
 common_types = { workspace = true }
 futures = { workspace = true }

partition_table_engine/src/lib.rs

@@ -20,6 +20,7 @@ mod partition;
 
 use std::sync::Arc;
 
+use analytic_engine::TableOptions;
 use async_trait::async_trait;
 use generic_error::BoxError;
 use snafu::{OptionExt, ResultExt};
@@ -67,7 +68,9 @@ impl TableEngine for PartitionTableEngine {
             partition_info: request.partition_info.context(UnexpectedNoCause {
                 msg: "partition info not found",
             })?,
-            options: request.options,
+            options: TableOptions::from_map(&request.options, true)
+                .box_err()
+                .context(Unexpected)?,
             engine_type: request.engine,
         };
         Ok(Arc::new(

partition_table_engine/src/partition.rs

@@ -16,6 +16,7 @@
 
 use std::{collections::HashMap, fmt};
 
+use analytic_engine::{table::support_pushdown, TableOptions};
 use async_trait::async_trait;
 use common_types::{
     row::{Row, RowGroupBuilder},
@@ -55,7 +56,7 @@ pub struct TableData {
     pub table_id: TableId,
     pub table_schema: Schema,
     pub partition_info: PartitionInfo,
-    pub options: HashMap<String, String>,
+    pub options: TableOptions,
     pub engine_type: String,
 }
 
@@ -109,7 +110,7 @@ impl Table for PartitionTableImpl {
 
     // TODO: get options from sub partition table with remote engine
     fn options(&self) -> HashMap<String, String> {
-        self.table_data.options.clone()
+        self.table_data.options.to_raw_map()
     }
 
     fn partition_info(&self) -> Option<PartitionInfo> {
@@ -124,6 +125,13 @@ impl Table for PartitionTableImpl {
         TableStats::default()
     }
 
+    // TODO: maybe we should ask remote sub table whether support pushdown
+    fn support_pushdown(&self, read_schema: &Schema, col_names: &[String]) -> bool {
+        let need_dedup = self.table_data.options.need_dedup();
+
+        support_pushdown(read_schema, need_dedup, col_names)
+    }
+
     async fn write(&self, request: WriteRequest) -> Result<usize> {
         let _timer = PARTITION_TABLE_WRITE_DURATION_HISTOGRAM
             .with_label_values(&["total"])

system_catalog/src/lib.rs

@@ -125,6 +125,10 @@ impl Table for SystemTableAdapter {
         TableStats::default()
     }
 
+    fn support_pushdown(&self, _read_schema: &Schema, _col_names: &[String]) -> bool {
+        false
+    }
+
     async fn write(&self, _request: WriteRequest) -> table_engine::table::Result<usize> {
         Ok(0)
     }

table_engine/src/memory.rs

@@ -118,6 +118,10 @@ impl Table for MemoryTable {
         TableStats::default()
     }
 
+    fn support_pushdown(&self, _read_schema: &Schema, _col_names: &[String]) -> bool {
+        false
+    }
+
     async fn write(&self, request: WriteRequest) -> Result<usize> {
         // TODO(yingwen) Maybe check schema?
         let mut row_groups = self.row_groups.write().unwrap();