refactor: pass the TaskContext when execute physical plan rather than holding it
#1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t param of `Executor::execute`.
ShiKaiWi
reviewed
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Part of #1112
I found we holding the execution context in
DataFusionPhysicalPlanImpl, rather than passing it as a param when executing like what datafusion suggests to do.It lead to problems when I plan to deserialize bytes to
DataFusionPhysicalPlanImpl...Detailed Changes
SessionContextfromDataFusionPhysicalPlanImpl.DfContextBuilderand use it to buildSessionContextinDatafusionExecutorImplandDatafusionPhysicalPlannerImpl.Test Plan
Test by exist tests.