fix: use ExecutionGuard to ensure notifiers released when futures got cancelled #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanruixiang
force-pushed
the
fix_disk_cache_cancel
branch
from
82d1581 to
758f4e6
Compare
jiacai2050
reviewed
Sep 11, 2023
jiacai2050
reviewed
Sep 11, 2023
jiacai2050
force-pushed
the
fix_disk_cache_cancel
branch
2 times, most recently
from
837796c to
76b533e
Compare
jiacai2050
changed the title
jiacai2050
force-pushed
the
fix_disk_cache_cancel
branch
from
76b533e to
787ed29
Compare
jiacai2050
force-pushed
the
fix_disk_cache_cancel
branch
from
787ed29 to
be2d5ba
Compare
jiacai2050
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Add ExecutionGuard to ensure notifiers go released when future got cancelled during
get_bytes, otherwise all ranges belonging to this notifiers will never receive response.Detailed Changes
Test Plan
Old UT.