Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: stream read metric #1203

Merged
merged 2 commits into from
Sep 11, 2023
Merged

refactor: stream read metric #1203

merged 2 commits into from
Sep 11, 2023

Conversation

baojinri
Copy link
Contributor

@baojinri baojinri commented Sep 8, 2023

Rationale

Now, we can't collect the time cost of stream read

Detailed Changes

  • Use drop trait to collect time cost of stream read

Test Plan

Existing tests

ShiKaiWi
ShiKaiWi approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit ad8d947 into apache:main Sep 11, 2023
6 checks passed
@baojinri baojinri deleted the refactor-metric branch December 5, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShiKaiWi ShiKaiWi ShiKaiWi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baojinri @ShiKaiWi