Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set and fetch environment variables error #1227

Merged
merged 2 commits into from
Sep 26, 2023
Merged

fix: set and fetch environment variables error #1227

merged 2 commits into from
Sep 26, 2023

Conversation

tanruixiang
Copy link
Member

@tanruixiang tanruixiang commented Sep 25, 2023 •
edited
Loading

Rationale

After #1226 changing directories , build.rs will not be used to set environment variables, ceresdb-server --verion will return None.

Detailed Changes

move build.rs intosrc/ceresdb/

Test Plan

add a test case to ensure all environment variables are got.

@tanruixiang
Copy link
Member Author

Please review this if you have time.❤️ @tisonkun

tisonkun
tisonkun approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your follow up!

@tanruixiang tanruixiang changed the title fix: fetch env var error fix: set and fetch environment variables error Sep 25, 2023
Rachelint
Rachelint approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanruixiang tanruixiang merged commit 0671597 into main Sep 26, 2023
@tanruixiang tanruixiang deleted the fix_env_get branch September 26, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@Rachelint Rachelint Rachelint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanruixiang @tisonkun @Rachelint