feat: support schema validate in remote write #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiKaiWi
force-pushed
the
feat-support-check-schema-for-remote-write
branch
from
aeabd22
to
14be627
Compare
jiacai2050
reviewed
Oct 11, 2023
| } | ||
| ); | ||
| } | ||
| Ok(()) |
ShiKaiWi
force-pushed
the
feat-support-check-schema-for-remote-write
branch
from
26f1d04
to
50df8b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The schema must be ensured to be correct during the remote write rpc call. Howerver, such check is missing now.
Detailed Changes
Introduce schema version check during remote write rpc call.
Test Plan
Add a new integration test for it.