-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: conditionally compile wal impls #1272
Conversation
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun How big is the final binary? Current size is 1.3G, which is a pain for distribution. |
@jiacai2050 with
|
Updated. PTAL again @jiacai2050 @ShiKaiWi |
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun If we turn on all the implementations in the default features, it will be better, and there is no need to update the dockerfile and the ci. 😄 |
Signed-off-by: tison <wander4096@gmail.com>
Updated. PTAL again. BTW, golang related CI failed with a new issue:
|
Perhaps we should setup go toolchain in the CI env. |
CI passed. PTAL @jiacai2050 @ShiKaiWi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Rationale
Supersede #1231
After compile time with clean -
Detailed Changes
Conditionally compile wal impls with feature flags.
Test Plan
Code refactor. All existing tests should pass.