feat: avoid pulling unnecessary columns when querying append mode table #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
force-pushed
the
avoid-pulling-unnecessary-columns
branch
3 times, most recently
from
48e29cf
to
78e4e25
Compare
Rachelint
force-pushed
the
avoid-pulling-unnecessary-columns
branch
from
5cb0d04
to
eba48ba
Compare
Rachelint
force-pushed
the
avoid-pulling-unnecessary-columns
branch
from
1e43ff9
to
3c0c4c0
Compare
Rachelint
force-pushed
the
avoid-pulling-unnecessary-columns
branch
from
3c0c4c0
to
45a8788
Compare
ShiKaiWi
reviewed
Dec 19, 2023
Rachelint
force-pushed
the
avoid-pulling-unnecessary-columns
branch
from
479c0e6
to
f70da9b
Compare
jiacai2050
approved these changes
Dec 22, 2023
tanruixiang
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Closes #1302
The pulling arrow record batches are ensured to include primary key columns, however the pulled primary key columns are unused for append mode tables' queries.
I refactor the whole record batches pulling path in this pr for readability and enhancement for avoiding pulling primary key columns even they are unused.
Detailed Changes
RowProjectortoRecordFetchingContextholding just the needed information, and pass it toScanRequest&SstReadOptionsrather than the too heavyProjectedSchema.RecordBatchWithKeytoFetchingRecordBatchwhich holds the primary indexes on demand.Test Plan
Test by exist and new added tests.