Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: try load page indexes #1425

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Conversation

jiacai2050
Copy link
Contributor

Rationale

See #1040

Detailed Changes

  • Try load page indexes

Test Plan

CI

@jiacai2050 jiacai2050 requested review from Rachelint and ShiKaiWi and removed request for Rachelint January 4, 2024 08:29
parquet_meta_data.clone(),
);

if let Ok(page_indexes) =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

page_indexes --> meta_data?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 5377dfd into apache:dev Jan 4, 2024
6 checks passed
@jiacai2050 jiacai2050 deleted the feat/page-filter branch January 4, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants