Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: table name is normalized when find timestamp column #1446

Merged
merged 5 commits into from
Jan 22, 2024
Merged

fix: table name is normalized when find timestamp column #1446

merged 5 commits into from
Jan 22, 2024

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Jan 19, 2024 •
edited
Loading

Rationale

Detailed Changes

  • Use get_table_ref to get TableReference, which will not normalize table name
  • Return error when timestamp column is not found.

Test Plan

CI

ZuLiangWang
ZuLiangWang previously approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@ZuLiangWang ZuLiangWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ZuLiangWang
ZuLiangWang approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@ZuLiangWang ZuLiangWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZuLiangWang ZuLiangWang merged commit 264826e into apache:main Jan 22, 2024
6 checks passed
@jiacai2050 jiacai2050 deleted the fix-priority branch January 22, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZuLiangWang ZuLiangWang ZuLiangWang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiacai2050 @ZuLiangWang