feat: sort record batch of write request #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
reviewed
Nov 4, 2024
horaedb/metric_engine/src/storage.rs
Outdated
| .context("execute sort physical plan")?; | ||
|
|
||
| let mut batches = Vec::new(); | ||
| while let Some(batch) = stream.next().await { |
There was a problem hiding this comment.
The batch return from next() may not equals input, there are no guarantees for that.
jiacai2050
reviewed
Nov 4, 2024
horaedb/metric_engine/src/storage.rs
Outdated
| @@ -69,6 +79,7 @@ pub struct CloudObjectStorage { | |||
| path: String, | |||
| store: ObjectStoreRef, | |||
| arrow_schema: SchemaRef, | |||
| primary_key_indexs: Vec<usize>, | |||
There was a problem hiding this comment.
I think we use num_primary_key: usize, it's more easier to use, and have no heap memory allocation.
0..num_primary_keys columns are primary key.
baojinri
force-pushed
the
feat-sort-record-batch
branch
from
9aab88b
to
9441536
Compare
jiacai2050
reviewed
Nov 4, 2024
horaedb/metric_engine/src/storage.rs
Outdated
| let batch_plan = | ||
| MemoryExec::try_new(&[vec![batch]], schema, None).context("build batch plan")?; | ||
| let physical_plan = SortExec::new(physical_sort_exprs, Arc::new(batch_plan)); | ||
| let mut stream = physical_plan |
There was a problem hiding this comment.
Please use collect to fetch results.
Your solution only works for single partition plan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Support sorted record batch of write request by primary key.
Detailed Changes
Test Plan