Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: skip add sequence column when compact #1618

Merged
merged 5 commits into from
Dec 24, 2024
Merged

feat: skip add sequence column when compact #1618

merged 5 commits into from
Dec 24, 2024

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Dec 24, 2024 •
edited
Loading

Rationale

Detailed Changes

  • Refactor package metadata
  • ParquetReader add keep_sequence args, and set it to truefor compaction, false for query.

Test Plan

CI

 cargo publish --dry-run --registry crates-io

This commands run successfully.

@github-actions github-actions bot added the chore label Dec 24, 2024
@jiacai2050 jiacai2050 changed the title chore: make it publish-able feat: skip add sequence column when compact Dec 24, 2024
@github-actions github-actions bot added the feature New feature or request label Dec 24, 2024
@jiacai2050 jiacai2050 removed the chore label Dec 24, 2024
baojinri
baojinri approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@baojinri baojinri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baojinri baojinri merged commit 47dd645 into apache:main Dec 24, 2024
8 checks passed
@jiacai2050 jiacai2050 deleted the chore-cargo branch December 24, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baojinri baojinri baojinri approved these changes

@zealchen zealchen Awaiting requested review from zealchen

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiacai2050 @baojinri