Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build guidance for mac users #169

Merged
merged 3 commits into from
Aug 5, 2022
Merged

Add build guidance for mac users #169

merged 3 commits into from
Aug 5, 2022

Conversation

tianlinzx
Copy link
Contributor

Which issue does this PR close?

Closes #96

Rationale for this change

What changes are included in this PR?

I have scripted the prerequirements and tested on MacOS Monterey.

Are there any user-facing changes?

How does this change test

@CLAassistant
Copy link

CLAassistant commented Aug 4, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

README.md Outdated Show resolved Hide resolved
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tianlinzx Thansk for your contributions. I have left some tiny suggestions and would you like to take a look.

README-CN.md Outdated Show resolved Hide resolved
README-CN.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@tianlinzx
Copy link
Contributor Author

@ShiKaiWi I have acceptted all your changes and committed again.

@tianlinzx tianlinzx requested a review from ShiKaiWi August 5, 2022 05:30
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tianlinzx Thanks!

@ShiKaiWi ShiKaiWi dismissed jiacai2050’s stale review August 5, 2022 06:13

Changes have been committed already.

@ShiKaiWi ShiKaiWi merged commit cb96b5f into apache:main Aug 5, 2022
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* Add build guidance for mac users

* Enhance build guidance for mac users

* Formatting enhancement build guidance for mac users
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build guidance for mac users
4 participants