chore: bump rust toolchain edition to 2021 #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
jiacai2050
reviewed
Aug 9, 2022
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
This reverts commit 8dee2d6.
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* chore: bump rust toolchain edition to 2021 Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * remove per crate edition Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * bump toolchain to nightly-2022-08-08 Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * Revert "remove per crate edition" This reverts commit 8dee2d6. * use workspace edition setting Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * also set edition for table_kv component Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * make clippy happy Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruihang Xia waynestxia@gmail.com
Which issue does this PR close?
Closes #143
Rationale for this change
Some of our crates (like client-rs) have bumped to edition 2021.
Besides that, I want to default to "resolver 2" for conditionally enable feature gate for
dev-dependencies(https://doc.rust-lang.org/cargo/reference/resolver.html#feature-resolver-version-2)What changes are included in this PR?
bump edition for all sub-crates.
Are there any user-facing changes?
no
How does this change test
I can build and run all test after this change.